Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Regenerate worker protocol protos to add constructors and comments #78

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

parlough
Copy link
Contributor

@parlough parlough commented Aug 30, 2023

Regenerate with package:protoc_plugin v21.1.1 to add doc comments and constructors with named parameters to the generated proto messages.

tool/update_proto.sh Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@parlough parlough changed the title Regenerate worker protocol protos to add comments Regenerate worker protocol protos to add constructors and comments Aug 31, 2023
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jakemac53
Copy link
Contributor

Actually, see this publish hint https://github.com/dart-lang/bazel_worker/actions/runs/6040700781/job/16392081805#step:5:127. Would you mind updating the max SDK constraint to <4.0.0 also?

@jakemac53
Copy link
Contributor

Also, @parlough would you mind trying adding the following to our .github/workflows/publish.yaml file:

jobs:
  publish:
    uses: ...
    // Add this stuff here
    permissions:
      pull-requests: write

We are supposed to be getting some comments here from the publish action.

@parlough
Copy link
Contributor Author

parlough commented Aug 31, 2023

Also, @parlough would you mind trying adding the following to our .github/workflows/publish.yaml file:

jobs:
  publish:
    uses: ...
    // Add this stuff here
    permissions:
      pull-requests: write

We are supposed to be getting some comments here from the publish action.

I think this is due to dart-lang/ecosystem#156 and the PR being from my fork.

@jakemac53
Copy link
Contributor

(feel free to say no and I can manually push the tags too, but it would be nice to get the workflow working and now is a good chance)

@jakemac53
Copy link
Contributor

I think this is due to dart-lang/ecosystem#156 and the PR being from my fork.

Ohhhh right, it is. Oh well, no worries then.

@parlough
Copy link
Contributor Author

Sounds good. Updated to explicitly support Dart 3 :)

@jakemac53 jakemac53 merged commit f950bbf into dart-archive:master Aug 31, 2023
5 checks passed
@jakemac53
Copy link
Contributor

Thanks @parlough ! This is published now 🚀

@parlough parlough deleted the misc/regenerate-protos branch August 31, 2023 18:16
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
…art-archive/bazel_worker#78)

Regenerate with `package:protoc_plugin` v21.1.1 to add doc comments and constructors with named parameters to the generated proto messages.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants