This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Adding additional Chrome environment variables for executable resolution. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Mar 18, 2021
|
done! |
grouma
approved these changes
Mar 18, 2021
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
…ion. (dart-archive/browser_launcher#24) * Adding additional Chrome environment variables to executable resolution. * Updating changelog and version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently browser_launcher.dart expects the Chrome exec to be in
CHROME_EXECUTABLE, but our test bots store this inCHROME_PATH. A quick search in codesearch reveals both to be pretty common environment variables.This'll be easier than modifying environment variables in the build system or from within the new suite of eval tests.