Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Fix internal CI test failures #35

Merged

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Dec 9, 2022

Chrome

  • Add error logging to chrome launcher

Tests

  • Add environment variable to detect headless-only mode (run by some CI)
  • Run all tests in headless mode, if compatible
  • Run all tests in normal mode if headless-only mode is not detected
  • Add waits and retries for some operations

Closes: dart-lang/tools#745

@annagrin annagrin marked this pull request as draft December 9, 2022 00:44
@annagrin annagrin marked this pull request as ready for review December 9, 2022 00:45
lib/src/chrome.dart Outdated Show resolved Hide resolved
lib/src/chrome.dart Outdated Show resolved Hide resolved
@annagrin annagrin merged commit 2712dda into dart-archive:master Dec 13, 2022
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
* Addeed headless-only mode for tests, added headless tests

* Remove redundant waits, fix flakes

* Fix flakes

* Enable debugger and runtime for expression evalaution

* Address CR comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add tests in headless mode
3 participants