This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm OOO until Thursday so maybe Nate or Kevin or Andrew can help? |
Travis is unhappy because |
Looks like you need to |
Kevin, I think there may be a breaking change to dartfmt between versions. We can get either 1.22 or 1.23 passing, but not both. |
Not sure how to make two different versions of |
We just need to ignore the lint for the other run |
Is there a variable I can check in tool/presubmit.sh to only perform the |
You can look at ENV |
kevmoo
approved these changes
May 2, 2017
Presubmit updated. PTAL |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* upgrade to new analyzer API * bump version to 1.0.2 * dartfmt unrelated file from earlier PR to make travis happy * only check dartfmt on stable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the internals to use the newer analyzer API so that code_builder can be used with both analyzer 0.29.11 and 0.30.