This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
Added support for switch and break statements #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passing on stable, failing on dev. The reasons it's failing on dev don't seem to be related to my commits |
matanlurey
reviewed
Jan 9, 2017
| @@ -0,0 +1,27 @@ | |||
| import 'package:analyzer/analyzer.dart'; | |||
There was a problem hiding this comment.
Please add the BSD header.
| import 'package:code_builder/src/tokens.dart'; | ||
|
|
||
| /// Represents a break statement AST. | ||
| abstract class BreakStatementBuilder implements StatementBuilder { |
There was a problem hiding this comment.
Can we just replace this with a singleton instance, i.e.
const breakStatement = const _BreakStatementBuilder();
There was a problem hiding this comment.
Sure, I'll apply the edits when I get home today.
There was a problem hiding this comment.
Ok, @matanlurey , I have made the edits.
|
Thanks for the contribution. Dev-channel failure looks related to a pkg/test regression. |
|
Of course, any time! :)
…On Jan 10, 2017 12:34 AM, "Matan Lurey" ***@***.***> wrote:
Merged dart-archive/code_builder#56 <#56>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#56 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJiKPEt5xzSaTwT0OiDWFSik51_97rWWks5rQxhMgaJpZM4LdzkI>
.
|
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
…der#56) * Added switch statements, and break statements * Edited test * dartfmt on break.dart * BSD header and more
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dart-lang/tools#969. 😄