This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
Allow quotes and newlines in string literal #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows creating string literals like “hello ‘world’” and “””hello\nworld”””.
matanlurey
approved these changes
Mar 1, 2017
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
…r#88) Allows creating string literals like “hello ‘world’” and “””hello\nworld”””.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creating string literals like “hello 'world'” and multiline string literals:
This change assumes that users of this package provide string literals like they would provide raw text (
r"text"in normal Dart). Since we escape', we also escape\, and therefore every other magic sequence (including\n,\tetc.). I think that's a reasonable assumption.