Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Clean the output of generator: Use /// comments and run dartfmt/dart_style on output. #172

Open
3 of 5 tasks
mkustermann opened this issue Sep 5, 2017 · 2 comments
Open
3 of 5 tasks

Clean the output of generator: Use /// comments and run dartfmt/dart_style on output. #172

mkustermann opened this issue Sep 5, 2017 · 2 comments
Assignees
@kevmoo

Comments

@mkustermann
Copy link
Contributor

mkustermann commented Sep 5, 2017 •
edited
Loading

  • New style-guide: Use /// comments
  • Run new dart_style/dartfmt on output
  • Change generated sdk constraint to be <2.0.0-dev.infinity.
  • Remove unnecessary parenthesis from (a).toJson()
  • New style-guide: Use camelCase constant naming (consider adding a flag)
@jakobr-google
Copy link
Contributor

While here, update SDK constraint in emitted pubspec.yaml to <2.0.0-dev.infinity?

Third bullet is also #131.

@mkustermann mkustermann mentioned this issue Sep 11, 2017
Closed
@mkustermann mkustermann self-assigned this Sep 11, 2017
mkustermann added a commit that referenced this issue Sep 11, 2017
@mkustermann
Change api generator to use new-style /// comments and run dartformat…
68b5311 
…ter on generated code

Issue #172

[email protected]

Review-Url: https://codereview.chromium.org//3009283002 .
@mkustermann
Copy link
Contributor Author

We have to U-turn on the infinity sdk constraint after the new guidelines. PR is #175

@kevmoo kevmoo assigned kevmoo and unassigned mkustermann Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevmoo kevmoo

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @mkustermann @jakobr-google