This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Improved generated comments #16
Merged
dcharkes
merged 4 commits into
dart-archive:master
from
mannprerak2:improved_generated_comments
Jun 30, 2020
Merged
Improved generated comments #16
dcharkes
merged 4 commits into
dart-archive:master
from
mannprerak2:improved_generated_comments
Jun 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments can be configured from config with the following comment types: - full - removes comment markup and trims lines. - brief - wraps the comment to the given line width. - none - no comments are added to bindings.
There's an issue with libclang's comment generation. |
Please open an issue on the clang issue tracker. Possible workarounds:
If we're in case 2, maybe just leave it as is + open an issue here + link to the clang issue. |
dcharkes
approved these changes
Jun 29, 2020
If an enum value declaration has no comment attached to it, libclang assigns it the comment of previous enum value declaration. This is fixed by comparing the current comment's source range with the previous one and removing the current one if its a duplicate.
dcharkes
approved these changes
Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16
clang_bindings.dart
)libclang-example/generated_bindings.dart
)