Remove span stuff from !generateSpans tests

dart-archive · Jul 4, 2024 · 3ee0eaa · 3ee0eaa
1 parent 7992c72
commit 3ee0eaa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/lib/parser.dart b/lib/parser.dart
@@ -3959,6 +3959,9 @@ class ParseError implements SourceSpanException {
 
   @override
   String toString({dynamic color}) {
+    if (span == null) {
+      return message;
+    }
     final res = span!.message(message, color: color);
     return span!.sourceUrl == null ? 'ParserError on $res' : 'On $res';
   }

diff --git a/test/parser_feature_test.dart b/test/parser_feature_test.dart
@@ -77,9 +77,6 @@ On line 4, column 3 of ParseError: Unexpected DOCTYPE. Ignored.
     expect(parser.errors.length, 1);
     final error = parser.errors[0];
     expect(error.errorCode, 'unexpected-doctype');
-    expect(error.span!.start.line, 3);
-    // Note: error position is at the end, not the beginning
-    expect(error.span!.start.column, 17);
   });
 
   test('text spans should have the correct length', () {
@@ -256,12 +253,7 @@ On line 4, column 3 of ParseError: Unexpected DOCTYPE. Ignored.
         'Unexpected non-space characters. Expected DOCTYPE.');
     expect(
         parser.errors[0].toString(),
-        'ParserError on line 1, column 4: Unexpected non-space characters. '
-        'Expected DOCTYPE.\n'
-        '  ╷\n'
-        '1 │ foo\n'
-        '  │    ^\n'
-        '  ╵');
+        'Unexpected non-space characters. Expected DOCTYPE.');
   });
 
   test('Element.text', () {