-
Notifications
You must be signed in to change notification settings - Fork 265
Add avoid non null assertion rule #285
Add avoid non null assertion rule #285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 73.01% 73.14% +0.13%
==========================================
Files 108 109 +1
Lines 3272 3296 +24
==========================================
+ Hits 2389 2411 +22
- Misses 883 885 +2
Continue to review full report at Codecov.
|
Just got an email notification about this PR and I think it is great rule! I already seen a feature request asking to implement exactly the same in dart linter repository Lint rule for ! postfix bang/exclamation and late null safety language features |
Yeah, I've actually seen this issue and decided to add this feature. Unfortunately there is no rule requests in our repo yet, hope this will change in the future. |
location: nodeLocation( | ||
node: expression, | ||
source: source, | ||
withCommentOrMetadata: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@incendial please remove withCommentOrMetadata: true,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain: