Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an option to redirect all not found to a specific asset #3361

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jodinathan
Copy link

this helps development of SPA like AngularDart, ie: not-found-defaults-to=web/index.html

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @natebosch thoughts on exposing this functionality?

build_runner/lib/src/entrypoint/options.dart Outdated Show resolved Hide resolved
build_runner/lib/src/server/server.dart Outdated Show resolved Hide resolved
@natebosch
Copy link
Member

I think we discussed a similar feature I wanted to add in the past and settled on not adding it. I don't have strong opinions on it today.

Is it feasible to write a proxy that handles this?

I can't recall - do we allow passing arbitrary flags through to build_runner when building with webdev? Would this impact any of the usage of reading assets by webdev?

@jodinathan
Copy link
Author

@jakemac53 will you merge it?

@@ -8,17 +8,16 @@

- Upgrade to `frontend_service_client` version 3.

## 2.3.0

## 2.3.3-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should remain as it was, there is a section higher up already for 2.3.3-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants