#1260: Added tests for Finalizer.attach method.

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A01_t01.dart

@@ -30,21 +30,21 @@ final Finalizer finalizer = Finalizer((token) {
   cnt++;
 });
 
-main() {
+main() async {
   {
     Object ? obj = Object();
     finalizer.attach(obj, "Just a string");
     print(obj);
   }
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
   Expect.equals("Just a string", returnedToken);
 
   {
     Object? obj = A();
     finalizer.attach(obj, 15);
     print(obj);
     obj = null;
-    triggerGcWithDelay();
+    await triggerGcWithDelay();
     Expect.equals(15, returnedToken);
   }
 
@@ -53,7 +53,7 @@ main() {
     finalizer.attach(obj, []);
     print(obj);
     obj = A();
-    triggerGcWithDelay();
+    await triggerGcWithDelay();
     Expect.equals([], returnedToken);
   }
 

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A01_t02.dart

@@ -27,13 +27,13 @@ final Finalizer finalizer = Finalizer((token) {
   cnt++;
 });
 
-main() {
+main() async {
   A detachToken = A();
   {
     Object value = Object();
     finalizer.attach(value, "Finalization token", detach: detachToken);
     finalizer.detach(detachToken);
   }
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
   Expect.equals(0, cnt);
 }

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A01_t03.dart

@@ -30,21 +30,21 @@ final Finalizer<int> finalizer = Finalizer((token) {
   cnt++;
 });
 
-main() {
+main() async {
   {
-    Object ? obj = Object();
+    Object? obj = Object();
     finalizer.attach(obj, 1);
     print(obj);
   }
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
   Expect.equals(1, returnedToken);
 
   {
     Object? obj = A();
     finalizer.attach(obj, 15);
     print(obj);
     obj = null;
-    triggerGcWithDelay();
+    await triggerGcWithDelay();
     Expect.equals(15, returnedToken);
   }
 
@@ -53,7 +53,7 @@ main() {
     finalizer.attach(obj, 14);
     print(obj);
     obj = A();
-    triggerGcWithDelay();
+    await triggerGcWithDelay();
     Expect.equals([], returnedToken);
   }
 

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A01_t04.dart

@@ -27,13 +27,13 @@ final Finalizer<Object> finalizer = Finalizer((token) {
   cnt++;
 });
 
-main() {
+main() async {
   A detachToken = A();
   {
     Object value = Object();
     finalizer.attach(value, "Finalization token", detach: detachToken);
     finalizer.detach(detachToken);
   }
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
   Expect.equals(0, cnt);
 }

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A02_t01.dart

@@ -18,29 +18,29 @@ final Finalizer finalizer = Finalizer((_) {
   called = true;
 });
 
-void test(Object o) {
-  triggerGcWithDelay();
+void test(Object o) async {
+  await triggerGcWithDelay();
   Expect.isFalse(called);
 }
 
 Object test1(Object obj) => obj;
 
-main() {
+main() async {
   Object value = Object();
   finalizer.attach(value, "Finalization token");
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
   Expect.isFalse(called);
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
   Expect.isFalse(called);
   test(value);
 
   Object value1 = value;
   value = 12345;
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
   Expect.isFalse(called);
 
   var value2 = test1(value1);
   value1 = value;
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
   Expect.isFalse(called);
 }

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A02_t02.dart

@@ -19,12 +19,12 @@ final Finalizer finalizer = Finalizer((_) {
 });
 
 void test(Object o) {
-  triggerGcWithDelay();
+  triggerGc();
 }
 
 Object test1(Object obj) => obj;
 
-main() {
+main() async {
   Object value = Object();
   finalizer.attach(value, "Finalization token");
 
@@ -34,12 +34,15 @@ main() {
   // Do something, call triggerGC several times and check that callback was
   // called only once during the execution.
   test(value);
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
 
   var value1 = test1(value);
-  triggerGcWithDelay();
-  triggerGcWithDelay();
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
+  triggerGc();
+  await triggerGcWithDelay();
+  triggerGc();
+  triggerGc();
+  await triggerGcWithDelay();
 
   Expect.equals(1, called);
 }

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A03_t01.dart

@@ -25,7 +25,7 @@ void test(Object o) {
 
 Object test1(Object obj) => obj;
 
-main() {
+main() async {
   Object value = Object();
   Object detachToken = A();
   finalizer.attach(value, "Finalization token", detach: detachToken);
@@ -38,10 +38,11 @@ main() {
   // Do something, call triggerGC several times and check that callback was
   // not called during the execution.
   test(value);
-  triggerGcWithDelay();
+  await triggerGcWithDelay();
 
   var value1 = test1(value);
-  triggerGcWithDelay();
+  triggerGc();
+  await triggerGcWithDelay();
   triggerGcWithDelay();
   triggerGcWithDelay();
 

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t01.dart

@@ -5,11 +5,10 @@
 /// @assertion The value and detach arguments ... Both must be objects supported
 /// as an [Expando] key.
 ///
-/// @description Checks that [value] must be supported as an [Expando] keys.
+/// @description Checks that [value] must be supported as an [Expando] key.
 /// Test String.
 /// @author [email protected]
 
-import "../gc_utils_lib.dart";
 import "../../../Utils/expect.dart";
 
 final Finalizer finalizer = Finalizer((_) { throw "Should not reach here"; });

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t02.dart

@@ -5,11 +5,10 @@
 /// @assertion The value and detach arguments ... Both must be objects supported
 /// as an [Expando] key.
 ///
-/// @description Checks that [value] must be supported as an [Expando] keys.
+/// @description Checks that [value] must be supported as an [Expando] key.
 /// Test numbers.
 /// @author [email protected]
 
-import "../gc_utils_lib.dart";
 import "../../../Utils/expect.dart";
 
 final Finalizer finalizer = Finalizer((_) { throw "Should not reach here"; });

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t03.dart

@@ -5,11 +5,10 @@
 /// @assertion The value and detach arguments ... Both must be objects supported
 /// as an [Expando] key.
 ///
-/// @description Checks that [value] must be supported as an [Expando] keys.
+/// @description Checks that [value] must be supported as an [Expando] key.
 /// Test booleans.
 /// @author [email protected]
 
-import "../gc_utils_lib.dart";
 import "../../../Utils/expect.dart";
 
 final Finalizer finalizer = Finalizer((_) { throw "Should not reach here"; });

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t04.dart

@@ -5,11 +5,10 @@
 /// @assertion The value and detach arguments ... Both must be objects supported
 /// as an [Expando] key.
 ///
-/// @description Checks that [value] must be supported as an [Expando] keys.
+/// @description Checks that [value] must be supported as an [Expando] key.
 /// Test [Null].
 /// @author [email protected]
 
-import "../gc_utils_lib.dart";
 import "../../../Utils/expect.dart";
 
 final Finalizer finalizer = Finalizer((_) { throw "Should not reach here"; });

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t05.dart

@@ -5,7 +5,7 @@
 /// @assertion The value and detach arguments ... Both must be objects supported
 /// as an [Expando] key.
 ///
-/// @description Checks that [value] must be supported as an [Expando] keys.
+/// @description Checks that [value] must be supported as an [Expando] key.
 /// Test Test dart:ffi pointers.
 /// @author [email protected]
 

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t06.dart

@@ -5,7 +5,7 @@
 /// @assertion The value and detach arguments ... Both must be objects supported
 /// as an [Expando] key.
 ///
-/// @description Checks that [value] must be supported as an [Expando] keys.
+/// @description Checks that [value] must be supported as an [Expando] key.
 /// Test Test dart:ffi struct.
 /// @author [email protected]
 
@@ -22,8 +22,8 @@ class S extends Struct {
 
 main() {
   Pointer<S> p = calloc<S>();
+  S s = p.ref;
   try {
-    S s = p.ref;
     Expect.throws(() {
       finalizer.attach(p, "Finalization token");
     });

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t067.dart → LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t07.dart

@@ -5,7 +5,7 @@
 /// @assertion The value and detach arguments ... Both must be objects supported
 /// as an [Expando] key.
 ///
-/// @description Checks that [value] must be supported as an [Expando] keys.
+/// @description Checks that [value] must be supported as an [Expando] key.
 /// Test Test dart:ffi union.
 /// @author [email protected]
 
@@ -24,8 +24,8 @@ class U extends Union {
 
 main() {
   Pointer<U> p = calloc<U>();
+  U u = p.ref;
   try {
-    U u = p.ref;
     Expect.throws(() {
       finalizer.attach(u, "Finalization token");
     });

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t08.dart

@@ -0,0 +1,31 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// @assertion The value and detach arguments ... Both must be objects supported
+/// as an [Expando] key.
+///
+/// @description Checks that detach token must be supported as an [Expando] key.
+/// Test String.
+/// @author [email protected]
+
+import "../../../Utils/expect.dart";
+
+final Finalizer finalizer = Finalizer((_) { throw "Should not reach here"; });
+Object object = Object();
+
+main() {
+  Expect.throws(() {
+    finalizer.attach(object, "Finalization token", detach: "detachMe");
+  });
+
+  String s = "Just a string";
+  Expect.throws(() {
+    finalizer.attach(object, "Finalization token", detach: s);
+  });
+
+  dynamic d = s;
+  Expect.throws(() {
+    finalizer.attach(object, "Finalization token", detach: d);
+  });
+}

LanguageFeatures/FinalizationRegistry/Finalizer/attach_A04_t09.dart

@@ -0,0 +1,36 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// @assertion The value and detach arguments ... Both must be objects supported
+/// as an [Expando] key.
+///
+/// @description Checks that detach token must be supported as an [Expando] key.
+/// Test numbers.
+/// @author [email protected]
+
+import "../../../Utils/expect.dart";
+
+final Finalizer finalizer = Finalizer((_) { throw "Should not reach here"; });
+Object object = Object();
+
+main() {
+  Expect.throws(() {
+    finalizer.attach(object, "Finalization token", detach: 12345);
+  });
+
+  var i = 3.14;
+  Expect.throws(() {
+    finalizer.attach(object, "Finalization token", detach: i);
+  });
+
+  int j = -12934;
+  Expect.throws(() {
+    finalizer.attach(object, "Finalization token", detach: j);
+  });
+
+  dynamic d = -12.376;
+  Expect.throws(() {
+    finalizer.attach(object, "Finalization token", detach: d);
+  });
+}