Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

co19/LanguageFeatures/Constructor-tear-offs/equality_A03_t05 #1210

Closed
alexmarkov opened this issue Oct 5, 2021 · 1 comment
Closed

co19/LanguageFeatures/Constructor-tear-offs/equality_A03_t05 #1210

alexmarkov opened this issue Oct 5, 2021 · 1 comment
Assignees
@sgrekhov

Comments

@alexmarkov
Copy link

The expectation

co19/LanguageFeatures/Constructor-tear-offs/equality_A03_t05.dart

Line 30 in 3f79167

Expect.equals(f1_1 == f1_3, f1_3 == f1_5);

seems to be incorrect because f1_3 and f1_5 are instantiations of the same local function localFunction1, but f1_1 and f1_3 cannot be equal, because f1_1 is a generic uninstantiated localFunction1 and f1_3 is instantiated localFunction1<X>.

Correct expectation would be

Expect.equals(f1_1 == f1_2, f1_3 == f1_5);
@alexmarkov alexmarkov mentioned this issue Oct 5, 2021
Closed
@sgrekhov sgrekhov self-assigned this Oct 6, 2021
@sgrekhov
Copy link
Contributor

sgrekhov commented Oct 6, 2021

@alexmarkov thank you. Typo fixed

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 14, 2021
@athomas
[co19] Roll co19 to cd6510c8346444792b37f6f26feffcc234a44dd1
2ffbc47 
2021-10-14 [email protected] dart-lang/co19#1207. Constructor call tests added
2021-10-13 [email protected] Fixes dart-lang/co19#1207. Implementing Enum tests added
2021-10-13 [email protected] Fixes dart-lang/co19#1222. Change the test to expect correct behaviour
2021-10-12 [email protected] More fix for dart-lang/co19#523: one more Language/Metadata test which use reflection moved to LibTests/mirrors tests.
2021-10-12 [email protected] More fix for dart-lang/co19#523: one more Language/Metadata test which use reflection moved to LibTests/mirrors tests.
2021-10-12 [email protected] Remove extra `be` (dart-lang/co19#1220)
2021-10-12 [email protected] dart-lang/co19#1207. More enhanced enums tests grammar tests added
2021-10-12 [email protected] Remove extra `be` (dart-lang/co19#1217)
2021-10-12 [email protected] Remove extra `be` (dart-lang/co19#1216)
2021-10-12 [email protected] Remove extra `be` (dart-lang/co19#1214)
2021-10-12 [email protected] Remove extra `be` (dart-lang/co19#1215)
2021-10-11 [email protected] Remove extra `the` (dart-lang/co19#1213)
2021-10-11 [email protected] dart-lang/co19#1207. More enhanced enums tests grammar tests added
2021-10-11 [email protected] Fixes dart-lang/co19#1212. Use correct instance for the comparison
2021-10-08 [email protected] dart-lang/co19#1207. More grammar tests added and experimental flag added
2021-10-07 [email protected] dart-lang/co19#1207. Some grammar tests added
2021-10-06 [email protected] Fixes dart-lang/co19#1210. Typo fixed

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I29e9f5460540e09e46fb13820bc9a3fe28914d65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216665
Reviewed-by: Erik Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @alexmarkov