Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to 143ad7f74919b132951e447a547236e991d9f900 #1262

Closed
athomas opened this issue Jan 12, 2022 · 5 comments
Closed

Failures on [co19] Roll co19 to 143ad7f74919b132951e447a547236e991d9f900 #1262

athomas opened this issue Jan 12, 2022 · 5 comments
Assignees
@sgrekhov

Comments

@athomas
Copy link
Member

athomas commented Jan 12, 2022 •
edited
Loading

There are new test failures on [co19] Roll co19 to 143ad7f74919b132951e447a547236e991d9f900.

The tests

co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t04 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t05 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t06 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t07 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t07 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A02_t01 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t03 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t05 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t06 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t07 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Set-literals/syntax_compatibility_A01_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Spread-collections/TypeInference_A02_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Super-parameters/summary_A04_t01 RuntimeError (expected Pass)
co19/LanguageFeatures/Super-parameters/summary_A04_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/Super-parameters/type_inference_A01_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Super-parameters/type_inference_A05_t01 RuntimeError (expected Pass)

are failing on configurations

analyzer-asserts-strong-linux
analyzer-asserts-weak-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-strong-linux-x64-chrome
dart2js-hostasserts-weak-linux-x64-chrome
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome
dartk-strong-linux-debug-x64
dartk-strong-linux-release-x64
dartk-strong-win-release-x64
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-x64
dartk-weak-asserts-win-release-x64
dartkp-strong-linux-release-x64
dartkp-weak-asserts-linux-release-x64
@athomas
Copy link
Member Author

athomas commented Jan 12, 2022

Some tryjobs are still running, will update this issue when they've finished.

@sgrekhov sgrekhov self-assigned this Jan 12, 2022
@sgrekhov
Copy link
Contributor

@athomas there are Enhanced Enums and Super Paraneters tests failures. If failing test is ok shall I fill the issues? Or simply triage such failures as 'Featuer is not fully implemented'?

@athomas
Copy link
Member Author

athomas commented Jan 13, 2022

@sgrekhov I think it's ok to triage them as unimplemented. We do track these failures for the purposes of feature development elsewhere.

@athomas
Copy link
Member Author

athomas commented Jan 13, 2022

Some tryjobs are still running, will update this issue when they've finished.

The issue is up-to-date now.

@sgrekhov
Copy link
Contributor

Triaged

analyzer…  
Crash -> CompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t01 Enhanced Enums are not fully implemented
Pass -> Crash (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A02_t01 Enhanced Enums are not fully implemented
Pass -> MissingCompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Set-literals/syntax_compatibility_A01_t02 dart-lang/sdk#48004
new test -> Crash (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t04 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t05 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t06 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t07 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t02 Enhanced Enums are not fully implemented
analyzer...cfe...  
new test -> MissingCompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t03 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t04 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t06 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t07 Enhanced Enums are not fully implemented
analyzer...cfe...dart2js...dartdevk...dartk...dartkp...  
new test -> CompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t05 Enhanced Enums are not fully implemented
cfe...  
Pass -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Spread-collections/TypeInference_A02_t02 Fixed
new test -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Enhanced-Enum/semantics_A01_t07 Enhanced Enums are not fully implemented
co19/LanguageFeatures/Super-parameters/type_inference_A01_t04 Enhanced Enums are not fully implemented
cfe...dart2js...dartdevk...dartk...dartkp...  
new test -> CompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A03_t02 Enhanced Enums are not fully implemented
dart2js...dartdevk...dartk...dartkp...  
CompileTimeError -> RuntimeError (expected Pass)  
✔ co19/LanguageFeatures/Super-parameters/summary_A04_t01 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Super-parameters/summary_A04_t02 Enhanced Enums are not fully implemented
✔ co19/LanguageFeatures/Super-parameters/type_inference_A05_t01 Enhanced Enums are not fully implemented

sgrekhov pushed a commit that referenced this issue Jan 14, 2022
#1262. Roll failures fixed
0f50a2f
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 20, 2022
@athomas
[co19] Roll co19 to 73fa4da0cb5a6fec136a2ac045503770eed2b58f
f783bac 
2022-01-19 [email protected] Fixes dart-lang/co19#1275: Test expectations corrected.
2022-01-18 [email protected] Fixes dart-lang/co19#1274: LanguageFeatures/Super-parameters/summary_A04_t02 test corrected: Expect.approxEquals is used instead of Expect.equals for the double comparing.
2022-01-18 [email protected] Issue dart-lang/co19#1244: LanguageFeatures/Constructor-tear-offs/unnamed_constructor_A06_t01 test should not run for dart2js because it uses mirrors.
2022-01-14 [email protected] dart-lang/co19#1262. Roll failures fixed
2022-01-14 [email protected] dart-lang/co19#1258. Enhanced Enums semantics tests added
2022-01-14 [email protected] Fixes dart-lang/co19#1269. Missed default constructor added to enum declaration
2022-01-14 [email protected] Fixes dart-lang/co19#1273. Typo fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1271. Typo fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1270. Fix expected result values
2022-01-14 [email protected] Fixes dart-lang/co19#1268. Runtime type check fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1267. Error expectation added
2022-01-14 [email protected] Fixes dart-lang/co19#1266. Default value added to non-nullable parameter
2022-01-14 [email protected] Fixes dart-lang/co19#1272. Runtime type check fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1265. Invalid assignment fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1264. Super parameter name fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1263. Add default value to non-nullable parameter
2022-01-13 [email protected] dart-lang/co19#1258. Enhanced Enums semantics tests rewritten according to changed spec

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I7001196297890f485f4b506898fff8cff1b3a0d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228646
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @athomas