Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static members do not interfere with extension instance member invocations #2909

Closed
eernstg opened this issue Oct 2, 2024 · 0 comments
Closed
Assignees
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@eernstg
Copy link
Member

eernstg commented Oct 2, 2024

Adjust test to expect that a static member does not eliminate the applicability of an extension. See dart-lang/sdk#56818 for background information.

@sgrekhov sgrekhov self-assigned this Oct 2, 2024
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Oct 2, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 2, 2024
@eernstg eernstg closed this as completed in 213cde4 Oct 2, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 4, 2024
2024-10-04 [email protected] Fixes dart-lang/co19#2919. Fix new roll failures (dart-lang/co19#2920)
2024-10-03 [email protected] dart-lang/co19#2915. Add missing extension in syntax_A03_t01.dart (dart-lang/co19#2918)
2024-10-03 [email protected] Fixes dart-lang/co19#2915. Fix errors and typos in some null-aware elements tests (dart-lang/co19#2917)
2024-10-03 [email protected] Fixes dart-lang/co19#2906. Add digit separators 'parse' tests (dart-lang/co19#2916)
2024-10-03 [email protected] Fixes dart-lang/co19#2907. Update expected errors positions in grammar_A03_t01.dart (dart-lang/co19#2914)
2024-10-02 [email protected] dart-lang/co19#2906. Add digit separators tests (dart-lang/co19#2910)
2024-10-02 [email protected] dart-lang/co19#2907. Revert wrong change in grammar_A04_t01_part1.dart (dart-lang/co19#2913)
2024-10-02 [email protected] Fixes dart-lang/co19#2907. Update expected errors positions in grammar_A04_t01_part1.dart (dart-lang/co19#2912)
2024-10-02 [email protected] Fixes dart-lang/co19#2909. Fix extension applicability tests according to the updated spec (dart-lang/co19#2911)
2024-10-01 49699333+dependabot[bot]@users.noreply.github.com Bump the github-actions group with 2 updates (dart-lang/co19#2908)
2024-10-01 [email protected] dart-lang/co19#2559. Add tests for adding body to static members (dart-lang/co19#2905)
2024-09-30 [email protected] Fixes dart-lang/co19#2902. Add tests for an extension applicability (dart-lang/co19#2903)
2024-09-30 [email protected] Fixes dart-lang/co19#2901. Update expected errors for analyzer and CFE (dart-lang/co19#2904)
2024-09-27 [email protected] dart-lang/co19#2559. Fix typo in augmenting_enum_values_A05_t05.dart (dart-lang/co19#2900)
2024-09-27 [email protected] dart-lang/co19#2559. Add test that `EnumName` extension is not augmentable (dart-lang/co19#2899)
2024-09-27 [email protected] dart-lang/co19#2559. Add more tests for augmenting enum members and values. (dart-lang/co19#2897)
2024-09-27 [email protected] dart-lang/co19#2825. Add more grammar and terminology tests (dart-lang/co19#2885)
2024-09-27 [email protected] dart-lang/co19#2559. Fix accidental syntax errors (dart-lang/co19#2898)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Id70baf6e0f6a6ea62eb0b507bffc3c1fb39e71ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388007
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Development

No branches or pull requests

2 participants