-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dartfmt removes "?" in "()?" typed field #1224
Labels
Comments
Oof, that's bad. I'll take a look. |
Seem like a dart_style/lib/src/source_visitor.dart Line 2508 in a36eb20
|
munificent
added a commit
that referenced
this issue
May 25, 2023
munificent
added a commit
that referenced
this issue
May 25, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
May 30, 2023
This includes a single commit which fixes: dart-lang/dart_style#1224 This doesn't need to be coordinated with a pre-built SDK update. Change-Id: Ifaabfde1d0d3dc180cf65a1052ba8dcff3324013 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306122 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Bob Nystrom <[email protected]> Auto-Submit: Bob Nystrom <[email protected]>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Jun 6, 2023
Fixes: #52591 Bug: dart-lang/dart_style#1224 Change-Id: I5d87c487e036d69cb5e3ed3289f3b066132a8dea Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/306122 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306911 Auto-Submit: Bob Nystrom <[email protected]> Reviewed-by: William Hesse <[email protected]> Commit-Queue: William Hesse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While adding records support to built_value I thought I'd check the base case, and it doesn't quite work as dartfmt eats the
?
in the generated output.The text was updated successfully, but these errors were encountered: