Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expectations for 0108 #1223

Merged
merged 1 commit into from
May 19, 2023
Merged

Update expectations for 0108 #1223

merged 1 commit into from
May 19, 2023

Conversation

scheglov
Copy link
Contributor

I failed to notice that with my previous PR this test started to fail.
Does it look as a reasonable change in formatting to you?


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for a week or two of latency for initial review feedback.


@scheglov scheglov requested a review from munificent May 16, 2023 21:06
Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fine. The test is already around really gross code and if it formats slightly differently in the margin, that's OK.

@scheglov scheglov merged commit a36eb20 into dart-lang:main May 19, 2023
@scheglov scheglov deleted the update-0108 branch May 19, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants