Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support generic methods #1282

Merged
merged 5 commits into from
Nov 28, 2016
Merged

support generic methods #1282

merged 5 commits into from
Nov 28, 2016

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Nov 27, 2016 •
edited
Loading

This is not yet ready for review - I need to land other PRs, merge this to master, and re-gen the sample library docs.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Nov 27, 2016
@devoncarew
Copy link
Member Author

screen shot 2016-11-28 at 9 05 01 am

screen shot 2016-11-28 at 9 05 10 am

@devoncarew
Copy link
Member Author

@keertip - I kept the commit with the re-gened test docs separate to make the PR easier to review.

@eernstg
Copy link
Member

eernstg commented Nov 28, 2016

You're moving fast on this, with short notice. Thanks a lot!

keertip
keertip approved these changes Nov 28, 2016
View reviewed changes
Copy link
Collaborator

@keertip keertip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this.

@devoncarew devoncarew merged commit 41787d0 into master Nov 28, 2016
@kevmoo kevmoo deleted the support_generic_methods branch December 14, 2016 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keertip keertip keertip approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support generic method syntax
4 participants
@devoncarew @eernstg @keertip @googlebot