Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using SdkExtUriResolver. #2091

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Stop using SdkExtUriResolver. #2091

merged 1 commit into from
Dec 14, 2019

Conversation

scheglov
Copy link
Contributor

We don't support _sdkext anymore, only _embedder.yaml.

I'd like to remove SdkExtUriResolver in addition to changes done in https://dart-review.googlesource.com/c/sdk/+/128320

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 13, 2019
@jcollins-g
Copy link
Contributor

@scheglov LGTM assuming this is a noop.

@jcollins-g
Copy link
Contributor

FYI, #2092 will fix tryPublish error.

@scheglov scheglov merged commit 1e56a66 into dart-lang:master Dec 14, 2019
@scheglov scheglov deleted the stop-using-SdkExtUriResolver branch December 14, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scheglov @jcollins-g @googlebot