Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basehref for search box on non-root cases #2118

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Fix basehref for search box on non-root cases #2118

merged 2 commits into from
Jan 9, 2020

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Jan 9, 2020 •
edited
Loading

Fixes #2117.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 9, 2020
@jcollins-g jcollins-g mentioned this pull request Jan 9, 2020
Merged
devoncarew
devoncarew approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@coveralls
Copy link

coveralls commented Jan 9, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 93.892% when pulling 32476f5 on fix_search_box into e11f935 on master.

@jcollins-g jcollins-g merged commit 62d39a2 into master Jan 9, 2020
terrylucas
terrylucas reviewed Jan 9, 2020
View reviewed changes
Copy link

@terrylucas terrylucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcollins-g jcollins-g mentioned this pull request Mar 4, 2020
Merged
@jcollins-g jcollins-g deleted the fix_search_box branch April 27, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrylucas terrylucas terrylucas left review comments

@devoncarew devoncarew devoncarew approved these changes

@jdkoren jdkoren Awaiting requested review from jdkoren

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search has stopped working except on the root page
5 participants
@jcollins-g @coveralls @devoncarew @terrylucas @googlebot