Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how mustachio's AOT compiler works #3886

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

srawlins
Copy link
Member

This documentation has been a long-time coming. I have an improvement to the deduplication code. But in order to make any sense of what the current deduplication code does, why it could be better, and what the improvement does, I need to add these docs, which describe how the AOT compiler works in general, and particularly how the partial renderer functions are written and optimized.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Copy link
Member Author

cc @dart-lang/analyzer-team if you want to review this, keep in mind that I'd request you to be the same reviewer for an upcoming PR to improve the deduplication strategy in the mustachio AOT compiler.

@keertip
Copy link
Collaborator

keertip commented Oct 3, 2024

Great job on the documentation! Very detailed!

@srawlins
Copy link
Member Author

srawlins commented Oct 3, 2024

Thanks!

@srawlins srawlins merged commit b0328fd into dart-lang:main Oct 3, 2024
7 checks passed
@srawlins srawlins deleted the document-aot-compilers-2 branch October 3, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants