Eagerly free resources on CupertinoClient.close() (#1191)

dart-lang · May 2, 2024 · dd31e64 · dd31e64
1 parent ec73b19
commit dd31e64
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/pkgs/cupertino_http/CHANGELOG.md b/pkgs/cupertino_http/CHANGELOG.md
@@ -2,10 +2,11 @@
 
 * Upgrade to `package:ffigen` 11.0.0.
 * Bring `WebSocket` behavior in line with the documentation by throwing
-  `WebSocketConnectionClosed` rather `StateError` when attempting to send
+  `WebSocketConnectionClosed` rather than `StateError` when attempting to send
   data to or close an already closed `CupertinoWebSocket`.
 * Update minimum supported iOS/macOS versions to be in sync with the minimum
-  (best effort) supported for Flutter: iOS 12, macOS 10.14
+  (best effort) supported for Flutter: iOS 12, macOS 10.14.
+* Eagerly free resources on `CupertinoClient.close()`.
 
 ## 1.4.0
 

diff --git a/pkgs/cupertino_http/lib/src/cupertino_api.dart b/pkgs/cupertino_http/lib/src/cupertino_api.dart
@@ -1613,4 +1613,12 @@ class URLSession extends _ObjectHolder<ncb.NSURLSession> {
         onWebSocketTaskClosed: _onWebSocketTaskClosed);
     return task;
   }
+
+  /// Free resources related to this session after the last task completes.
+  /// Returns immediately.
+  ///
+  /// See [NSURLSession finishTasksAndInvalidate](https://developer.apple.com/documentation/foundation/nsurlsession/1407428-finishtasksandinvalidate)
+  void finishTasksAndInvalidate() {
+    _nsObject.finishTasksAndInvalidate();
+  }
 }
diff --git a/pkgs/cupertino_http/lib/src/cupertino_client.dart b/pkgs/cupertino_http/lib/src/cupertino_client.dart
@@ -228,6 +228,7 @@ class CupertinoClient extends BaseClient {
 
   @override
   void close() {
+    _urlSession?.finishTasksAndInvalidate();
     _urlSession = null;
   }