Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid passing a nullable value to Completer<nn-type>.complete #1015

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Avoid passing a nullable value to Completer<nn-type>.complete #1015

merged 1 commit into from
Sep 12, 2023

Commits on Aug 31, 2023

  1. Avoid passing a nullable value to Completer<nn-type>.complete 

    This is cleanup work required to start enforcing this with static analysis, as per dart-lang/sdk#53253.

Real quick this issue is that this code is unsafe:

```dart
void f(Completer<int> c, int? i) {
  Future<int>.value(i); // Ouch!
  c.complete(i);        // Ouch!
}
```
    @srawlins
    srawlins authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    cd341a2 View commit details
    Browse the repository at this point in the history