remove ignores #275
Closed
remove ignores #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My understanding: this breaks DDC if these are removed! |
|
These are necessary for build_web_compilers <2.0.0, the analyzer never properly implemented these imports so they give warnings when they shouldn't. This only happens at compile time when only one of those sources will be available to the analyzer (the one it should select). |
|
@jakemac53, is dart-lang/sdk#34179 the same issue? |
|
dart-lang/sdk#34177 is the one for imports |
|
We can close this out, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore: uri_does_not_existI don't think these are necessary anymore - I don't see analysis issues when I remove them.