add initial macro expansion protocol #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheglov
reviewed
Dec 8, 2021
johnniwinther
approved these changes
Dec 10, 2021
scheglov
reviewed
Dec 10, 2021
scheglov
reviewed
Dec 14, 2021
scheglov
reviewed
Dec 14, 2021
scheglov
reviewed
Dec 14, 2021
|
Merging this for now to get the ball rolling and we can keep iterating. Once I move it into the SDK repo it should be easier also. |
jakemac53
added a commit
that referenced
this pull request
Dec 15, 2021
Followup to #2021. This partially implements one possible version of the MacroExecutor interface, and is a port of my early experiments using `IsolateMirror.loadUri` to load and execute macros. I could fully flesh this out, if the implementation teams think that would be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
MacroExecutorinterface which is intended for use by language frontends (cfe, analyzer) in order to load and execute macros, as well as create library augmention files.This should help more clearly define the role of a frontend when it comes to macros (discovery and introspection), as well as provide a unified api for producing the final library augmentations.
It does not actually write files though, we still need to figure out how we want to coordinate that part, and make sure that the CFE and analyzer can consistently talk about these files.
This also allows for multiple different implementations in terms of how macros are actually loaded and executed, without the frontends having to know about them.
Followup PR here #2022 which starts an implementation using
IsolateMirror.loadUri.