Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust wording about extension vs. static method conflicts #2207

Merged
merged 3 commits into from
Apr 30, 2022

Conversation

eernstg
Copy link
Member

@eernstg eernstg commented Apr 19, 2022

The section about extensions in the language specification had an imprecise wording about conflicts involving an extension member (static or not) and a member of the class Object. This PR clarifies the text: Such conflicts only arise when the member of Object is an instance member.

@eernstg
Copy link
Member Author

eernstg commented Apr 19, 2022

@mit-mit, it looks like there's a need to fix the 'Failed to authenticate' failure again: https://github.com/dart-lang/language/runs/6075044920?check_suite_focus=true.

Copy link
Member Author

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now using the explicit listing.

specification/dartLangSpec.tex Outdated Show resolved Hide resolved
specification/dartLangSpec.tex Outdated Show resolved Hide resolved
specification/dartLangSpec.tex Show resolved Hide resolved
specification/dartLangSpec.tex Outdated Show resolved Hide resolved
Copy link
Member Author

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review response

specification/dartLangSpec.tex Show resolved Hide resolved
specification/dartLangSpec.tex Outdated Show resolved Hide resolved
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit cbe2331):

https://dart-specification--pr2207-specify-extension-st-kilfoor4.web.app

(expires Fri, 06 May 2022 13:22:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6941ecd630c4f067ff3d02708a45ae0f0a42b88a

@eernstg eernstg merged commit 70eb85c into master Apr 30, 2022
@eernstg eernstg deleted the specify_extension_static_conflict_apr22 branch April 30, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants