-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust wording about extension vs. static method conflicts #2207
Conversation
@mit-mit, it looks like there's a need to fix the 'Failed to authenticate' failure again: https://github.com/dart-lang/language/runs/6075044920?check_suite_focus=true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, now using the explicit listing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review response
Visit the preview URL for this PR (updated for commit cbe2331): https://dart-specification--pr2207-specify-extension-st-kilfoor4.web.app (expires Fri, 06 May 2022 13:22:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6941ecd630c4f067ff3d02708a45ae0f0a42b88a |
The section about extensions in the language specification had an imprecise wording about conflicts involving an extension member (static or not) and a member of the class
Object
. This PR clarifies the text: Such conflicts only arise when the member ofObject
is an instance member.