Move avoid_relative_lib_imports tests to reflective (#4104)

* Move avoid_relative_lib_imports tests to reflective

* remove-old-data

test/integration_test.dart

@@ -15,8 +15,6 @@ import 'package:yaml/yaml.dart';
 import '../test_data/rules/experiments/experiments.dart';
 import 'integration/always_require_non_null_named_parameters.dart'
     as always_require_non_null_named_parameters;
-import 'integration/avoid_relative_lib_imports.dart'
-    as avoid_relative_lib_imports;
 import 'integration/avoid_web_libraries_in_flutter.dart'
     as avoid_web_libraries_in_flutter;
 import 'integration/close_sinks.dart' as close_sinks;
@@ -163,7 +161,6 @@ void ruleTests() {
     lines_longer_than_80_chars.main();
     always_require_non_null_named_parameters.main();
     prefer_const_constructors_in_immutables.main();
-    avoid_relative_lib_imports.main();
     public_member_api_docs.main();
     secure_pubspec_urls.main();
     sort_pub_dependencies.main();

test/rules/all.dart

@@ -16,6 +16,7 @@ import 'avoid_private_typedef_functions_test.dart'
     as avoid_private_typedef_functions;
 import 'avoid_redundant_argument_values_test.dart'
     as avoid_redundant_argument_values;
+import 'avoid_relative_lib_imports_test.dart' as avoid_relative_lib_imports;
 import 'avoid_renaming_method_parameters_test.dart'
     as avoid_renaming_method_parameters;
 import 'avoid_returning_this_test.dart' as avoid_returning_this;
@@ -116,6 +117,7 @@ void main() {
   avoid_init_to_null.main();
   avoid_private_typedef_functions.main();
   avoid_redundant_argument_values.main();
+  avoid_relative_lib_imports.main();
   avoid_renaming_method_parameters.main();
   avoid_returning_this.main();
   avoid_setters_without_getters.main();

test/rules/avoid_relative_lib_imports_test.dart

@@ -0,0 +1,43 @@
+// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import '../rule_test_support.dart';
+
+main() {
+  defineReflectiveSuite(() {
+    defineReflectiveTests(AvoidRelativeLibImportsTest);
+  });
+}
+
+@reflectiveTest
+class AvoidRelativeLibImportsTest extends LintRuleTest {
+  @override
+  bool get addJsPackageDep => true;
+
+  @override
+  String get lintRule => 'avoid_relative_lib_imports';
+
+  test_externalPackage() async {
+    await assertNoDiagnostics(r'''
+/// This provides [JS].
+import 'package:js/js.dart';
+''');
+  }
+
+  test_samePackage_relativeUri() async {
+    newFile('$testPackageLibPath/lib.dart', r'''
+class C {}
+''');
+    var test = newFile('$testPackageRootPath/test/test.dart', r'''
+/// This provides [C].
+import '../lib/lib.dart';
+''');
+    var lib2Result = await resolveFile(test.path);
+    await assertDiagnosticsIn(lib2Result.errors, [
+      lint(30, 17),
+    ]);
+  }
+}