☂ downstream package updates to prepare for 1.4.0 (and improved directives_ordering)

[pq]

Linter 1.4.0 introduces directives_ordering updated to sort more cases (see #2596). In order to land in the Dart SDK (cl/196581), a number of downstream fixes need to be made to SDK and Flutter packages.

Dart SDK:

• https://dart-review.googlesource.com/c/sdk/+/196223
• https://dart-review.googlesource.com/c/sdk/+/196180

Flutter:

• Ignore directives ordering in generated sample code flutter/flutter#81017
• [path_provider_*] code cleanup: sort directives flutter/plugins#3823
• fix sort_directives violations flutter/flutter#80817
• fix unsorted directives flutter/flutter#80901
• fix unsorted directives flutter/flutter#81210

...

• (temporarily) disable sort_directives flutter/flutter#81220 (disable lint temporarily)
• re-enable directives_ordering flutter/flutter#81219 (re-enable once SDK lands)

(Some downstream packages):

• Fix newly enforced lint dart-archive/args#193
• fix sort_directives violations dart-archive/gcloud#112
• Fix newly enforced lint dart-archive/mime#46
• fix lint source_span#76
• Fix newly enforced lint io#76

[kevmoo]

I like the change, it just requires some follow-up on the package side.

[pq]

UPDATE: I've got yet one more change queued up to fix flutter (flutter/flutter#81210) but even then it's a race and there's a chance that violations will get introduced before the auto-roll.

@goderbauer: do you object to me disabling the lint until the next roll when I can re-enable it and fix up any newly introduced breakages?

[pq]

@kevmoo: 💯

To be honest, I wasn't expecting this broad impact. (Nor do I expect was @davidmorgan 😄.) Thinking ahead, it'd be great to have some way to get proactive about tracking soon to be breaking ecosystem packages so we can (ideally) fix them up proactively. @athomas and I were chatting about this a bit... Maybe we could leverage the index you have in repo_manager?

[pq]

FWIW, here's another breakage, unrelated to this change, that would have been nice to detect (and fix) proactively:

dart-archive/graphs#63

(fyi @bwilkerson @scheglov)

[goderbauer]

@goderbauer: do you object to me disabling the lint until the next roll when I can re-enable it and fix up any newly introduced breakages?

No objections. (I suspect there will still be a race between your change enabling it again and other changes, but maybe that race is easier to manage?)

[pq]

Right. It also has the advantage of something I can do and manage manually (as opposed to an auto-roll that just gets blocked).

[pq]

Linter 1.4.0 is re-landed in the SDK as of dart-lang/sdk@513c1a1. When it gets rolled into Flutter, I'll loop back and re-enable the lint in the Flutter options.

[pq]

Closed w/ flutter/flutter#81219. Downstream changes may continue to trickle in.