Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate integration tests to reflective tests #3535

Closed
Tracked by #4411
pq opened this issue Jul 19, 2022 · 2 comments
Closed
Tracked by #4411

migrate integration tests to reflective tests #3535

pq opened this issue Jul 19, 2022 · 2 comments
Assignees
@srawlins
Labels
P4 type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-task type-test

Comments

@pq
Copy link
Member

pq commented Jul 19, 2022

Now that we have reflective tests, we don't really need the existing integration tests so down the road we should remove them.
@pq pq added type-test type-task type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P4 labels Jul 19, 2022
@pq pq mentioned this issue Jul 19, 2022
Merged
This was referenced Jul 24, 2023
Closed
Merged
Merged
Merged
Merged
Merged
Merged
@srawlins srawlins self-assigned this Sep 19, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 19, 2023
@srawlins
linter: Move close_sinks tests
42516e3 
Work towards dart-lang/linter#3535

Change-Id: I5c2b076d5d01037aa50b829d29a899834e105181
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326861
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Auto-Submit: Samuel Rawlins <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 25, 2023
@srawlins
Move avoid_web_libraries_in_flutter tests
bdb450b 
Work towards dart-lang/linter#3535

Change-Id: I7adf8986b3e3ab5329599d608df6f90db8046179
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/327281
Auto-Submit: Samuel Rawlins <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
@srawlins
Copy link
Member

All rule integration tests are migrated. The only integration tests remaining are for configuration; perhaps only for bin/linter.dart.

@pq
Copy link
Member Author

pq commented Sep 26, 2023

The rule tests were what this issue was actually tracking. Thanks Sam!

@pq pq closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
P4 type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-task type-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @srawlins