Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish machine json #2362

Merged
merged 2 commits into from
Dec 9, 2020
Merged

publish machine json #2362

merged 2 commits into from
Dec 9, 2020

Conversation

pq
Copy link
Member

@pq pq commented Dec 7, 2020

Follow-up from #2359, adds machine json to the published docs.

See: https://dart-lang.github.io/linter/lints/machine/rules.json

Ultimate format and desired metadata still TBD.

(If desired we could pull this into tools_metadata as well but doing the work here feels right.)

/fyi @csells

/cc @devoncarew

@google-cla google-cla bot added the cla: yes label Dec 7, 2020
@coveralls
Copy link

coveralls commented Dec 7, 2020

Coverage Status

Coverage remained the same at 96.578% when pulling bc43cd1 on docs_machine_gen into ee40a72 on master.

@@ -61,14 +62,26 @@ These rules are under active development. Feedback is

const ruleLeadMatter = 'Rules are organized into familiar rule groups.';

final effectiveDartRules = <String>[];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the churn. The file was unsorted but should have been.

@@ -422,6 +321,22 @@ class RuleHtmlGenerator {
''';
}

class MachineSummaryGenerator {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only interestingly new bit.

@pq pq requested a review from devoncarew December 7, 2020 21:37
tool/doc.dart Show resolved Hide resolved
@pq pq merged commit 1455455 into master Dec 9, 2020
@pq pq deleted the docs_machine_gen branch December 9, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants