add noop_primitive_operations

[a14n]

Follow up on #2618

Description

Some operations on primitive types are idempotent and can be removed.

BAD:

doubleValue.toDouble();

intValue.toInt();
intValue.round();
intValue.ceil();
intValue.floor();
intValue.truncate();

string.toString();
string = 'hello\n'
    'world\n'
    ''; // useless empty string

[coveralls]

Coverage increased (+0.02%) to 94.306% when pulling 86aa11f on a14n:noop_primitive_operations into ba1b615 on dart-lang:master.

[pq]

💎

[pq]

Awesome. Love the generalization to noop_primitives... too. 👍

[a14n]

Awesome. Love the generalization to noop_primitives... too. 👍

Not sure to understand your comment. Do you suggest to rename the lint to noop_primitives_operations (plural for primitive) or were you talking about the merge of all noop_{int,double,string}_calls into this noop_primitive_operations?

[pq]

Sorry, I was sloppy with my language. I meant to celebrate the merge. Good stuff!

[pq]

@a14n : is this ready to land?

[a14n]

@a14n : is this ready to land?

Yes, thanks