-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_decorated_box
#3061
use_decorated_box
#3061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one missing test case, this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. And thanks for kicking off the thoughtful corresponding conversation in #3060! 👍
Could you add an attribution for yourself in AUTHORS
?
Thanks!
- `no_leading_underscores_for_library_prefixes` dart-lang/linter#3062 - `no_leading_underscores_for_local_identifiers` dart-lang/linter#3062 - `secure_pubspec_urls` dart-lang/linter#3056 - `use_decorated_box` dart-lang/linter#3061
* Add UseDecoratedBox * Add missing tests * Add to AUTHORS and nit description
Description
Use
DecoratedBox
overContainer
when onlyDecoration
is specified.Fixes #3060
Kind
Style advice.
Bad Example
Good Example