Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most remaining doc generation code #4585

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

parlough
Copy link
Member

This removes most remaining doc generation code, outside of the machine generated file (rules.json) which is still used by package:lints, dart.dev, a flutter sample, and perhaps elsewhere.

In the short term, we should perhaps check that file in to the main branch instead and have a test to make sure its up to date. Once that is done, we can remove the gh-pages workflow.

@coveralls
Copy link

coveralls commented Jul 20, 2023

Coverage Status

coverage: 96.731%. remained the same when pulling e8d22f0 on parlough:misc/remove-most-doc-generation-code into 9a070d2 on dart-lang:main.

@pq
Copy link
Member

pq commented Jul 20, 2023

In the short term, we should perhaps check that file in to the main branch instead and have a test to make sure its up to date.

I can take care of that! If you have a sec, could you open a tracking issue?

@parlough
Copy link
Member Author

That would be appreciated! #4587

@pq pq merged commit 26b307b into dart-lang:main Jul 20, 2023
6 checks passed
@parlough parlough deleted the misc/remove-most-doc-generation-code branch July 20, 2023 17:17
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
* Remove most remaining doc generation code

* Remove accidental lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants