Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source span on CR characters. #1021

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Fix source span on CR characters. #1021

merged 3 commits into from
Feb 25, 2022

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 23, 2022

Fixes #1014.

Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the source span in the linked issue not created somewhere else (related to license detection)?
Could this be fixed in source_span instead?

Do we need a test of this?

@isoos
Copy link
Collaborator Author

isoos commented Feb 24, 2022

Is the source span in the linked issue not created somewhere else (related to license detection)?
Could this be fixed in source_span instead?

We could wait for dart-lang/source_span#79 to be fixed, but I think we can also mitigate this by this PR, as we already have the try-catch block with a comment that CRs are causing trouble. Once the package:source_span issue is fixed, we can simplify this code. I'll add a TODO to note this.

Do we need a test of this?

Shall I add an end2end test case for it?

@sigurdm
Copy link
Contributor

sigurdm commented Feb 24, 2022

Shall I add an end2end test case for it?

Or perhaps just a unit-test. The end2end tests are a bit heavy.

@isoos isoos requested a review from sigurdm February 24, 2022 13:55
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isoos isoos merged commit 31c6827 into dart-lang:master Feb 25, 2022
@isoos isoos deleted the fix-span branch February 25, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License detection crashing for sqfentity version 1.2.3+10
2 participants