Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand broadNative runtime with nativeJit. #1109

Closed
wants to merge 1 commit into from

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Aug 5, 2022

Fixes #1028.

@isoos isoos requested a review from sigurdm August 5, 2022 17:27
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigurdm
Copy link
Contributor

sigurdm commented Aug 8, 2022

One can say it is surprising a package can get platform:android when it uses dart:mirrors. I don't think there is a way do deploy on android without flutter (where mirrors are not allowed)... but I'm not sure how important that is.

@isoos
Copy link
Collaborator Author

isoos commented Aug 8, 2022

One can say it is surprising a package can get platform:android when it uses dart:mirrors. I don't think there is a way do deploy on android without flutter (where mirrors are not allowed)... but I'm not sure how important that is.

I also think that this is strange, and I think it is a sign that we should do this differently.

@isoos
Copy link
Collaborator Author

isoos commented Oct 17, 2022

Closing as this seems to get us unintended side effects.

@isoos isoos closed this Oct 17, 2022
@isoos isoos deleted the tags-jit branch October 17, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include _onNativeJit in broadNative?
2 participants