-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate pub
command
#2736
Comments
We probably want to wrap |
Do we still need this after migrating to github code actions? |
note to self, patching travis involves:
|
Also makes the `pub` shell script (and its .bat counterpart) forward to a `dart __deprecated_pub` command that implements the old top-level. This allows us to get rid of pub.dart.snapshot saving ~15 MB in a unzipped sdk. The reason for not forwarding directly to `dart pub` is that the interface is slightly different (for example there is no `dart pub --version`). The only new commit in pub is: `3c2ce330 Expose toplevel as a command` Bug: dart-lang/pub#2736 Change-Id: I6eb08d120c4844b3a12bc29544df6a868cd6fcc8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210582 Commit-Queue: Sigurd Meldgaard <[email protected]> Reviewed-by: Jonas Jensen <[email protected]>
@sigurdm can this be closed now? |
I managed to commit out of order - we can close whenever: flutter/flutter#88509 lands. I hope to land it before flutter discovers that the sdk is broken for them :| |
Things to do:
flutter pub
to not wrappub
, butdart pub
instead.dart pub get
(fordart >= 2.10.0
) (wontfix for now)dart pub get
(fordart >= 2.10.0
)dart pub get
(fordart >= 2.10.0
),pana
to invoke throughdart pub
(Migrated from "pub" -> "dart pub" pana#852)pub-dev
to usedart pub
(Migrated from "pub" -> "dart pub" pub-dev#4655)pub
is invoked in a terminal.pub
to be a wrapper arounddart pub
.The text was updated successfully, but these errors were encountered: