pub upgrade command to show number of discontinued packages #2908
Conversation
|
@sigurdm PTAL. |
There was a problem hiding this comment.
Nice! Thanks for the contribution!
We need a test to test this behavior.
See https://github.com/dart-lang/pub/blob/5aadb70e0a59017968a4898b383798d7d507152e/test/get/hosted/warn_about_discontinued_test.dart for inspiration on how to set up a discontinued package in the test framework.
| /// Displays a single-line message, number of discontinued packages | ||
| /// if discontinued packages are detected. | ||
| Future<void> reportDiscontinued() async { | ||
| var numDiscontinued = 0; |
There was a problem hiding this comment.
Minor nit: follow the style from reportOutdated.
final discontinuedCount = result.packages.where((pkg) => ...).length;
There was a problem hiding this comment.
Yes, I tried to do it using where but the method needs to async which is not possible with it.
There was a problem hiding this comment.
Ah! - good point. Did not think of that. Then your solution is fine.
|
@sigurdm I have added a test case. PTAL. |
| @@ -50,6 +50,50 @@ void main() { | |||
| ]).validate(); | |||
| }); | |||
|
|
|||
| test('--dry-run: shows count of discontinued packages', () async { | |||
There was a problem hiding this comment.
| test('--dry-run: shows count of discontinued packages', () async { | |
| test('Shows count of discontinued packages', () async { |
There was a problem hiding this comment.
I think this test belongs better in for example test/upgrade/report/describes_change_test.dart . It does not really relate to dry-run.
| d.file('pubspec.lock', contains('2.0.0')), | ||
| // The ".dart_tool" directory should not have been regenerated. | ||
| d.nothing('.dart_tool') | ||
| ]).validate(); |
There was a problem hiding this comment.
I don't think we need this validation in this test. We want to test that we print the count, not how --dry-run behaves.
lib/src/solver/report.dart
Outdated
| if (numDiscontinued > 1) { | ||
| log.message('$numDiscontinued packages are discontinued.'); | ||
| } else if (numDiscontinued == 1) { | ||
| log.message('1 package is discontinued.'); | ||
| } |
There was a problem hiding this comment.
I think this would be slightly easier to follow:
| if (numDiscontinued > 1) { | |
| log.message('$numDiscontinued packages are discontinued.'); | |
| } else if (numDiscontinued == 1) { | |
| log.message('1 package is discontinued.'); | |
| } | |
| if (numDiscontinued > 0) { | |
| if (numDiscontinued == 1) { | |
| log.message('1 package is discontinued.'); | |
| } else { | |
| log.message('$numDiscontinued packages are discontinued.'); | |
| } | |
| } |
|
@sigurdm Thanks for the review! |
Description
I have added a message showing the number of discontinued packages for pub upgrade command.
Fixes #2865