Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to fail if extra arguments are passed #2927

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

tusharojha
Copy link
Contributor

Description

Added usage exception if extra arguments are passed.

Fixes #2923

cc @sigurdm @jonasfj

I am bit unsure whether to put the test case into add_test.dart or invalid_options.dart. So, as of now it's in add_test let me know if its needs to be changed.

@google-cla google-cla bot added the cla: yes label Mar 19, 2021
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@sigurdm sigurdm merged commit 3716a68 into dart-lang:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dart pub add" ignores extra options
2 participants