Detect Flutter SDK location relative to Dart SDK #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Dart SDK is present inside the Flutter SDK in sub-folder `bin/cache/dart-sdk/`, then we no-longer require the environment variable `FLUTTER_ROOT` to be specified. Instead we simply derive the location of the Flutter SDK from the location of the Dart SDK. We still allow the environment variable `FLUTTER_ROOT` to override the otherwise automatically detected Flutter SDK location.
|
@natebosch feel free to unassign review if you're busy, I'm just a little short on reviewers this summer 🌞 |
natebosch
reviewed
Jul 15, 2021
natebosch
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2307, tested on Windows and Linux using a few hacks.
If the Dart SDK is present inside the Flutter SDK in sub-folder
bin/cache/dart-sdk/, then we no-longer require the environmentvariable
FLUTTER_ROOTto be specified. Instead we simply derivethe location of the Flutter SDK from the location of the Dart SDK.
We still allow the environment variable
FLUTTER_ROOTto overridethe otherwise automatically detected Flutter SDK location.