Move UNIGNORABLE_IGNORE from HintCode to WarningCode

Work towards #50796 Change-Id: Idb8d04eb07beeb4f201ca69d0543d85305d62ea8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325127 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]> Auto-Submit: Samuel Rawlins <[email protected]>
dart-lang · Sep 12, 2023 · 252bfcb · 252bfcb
1 parent df54b81
commit 252bfcb
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 22 deletions.
diff --git a/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml b/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
@@ -1822,10 +1822,6 @@ HintCode.IMPORT_DEFERRED_LIBRARY_WITH_LOAD_FUNCTION:
 HintCode.IMPORT_OF_LEGACY_LIBRARY_INTO_NULL_SAFE:
   status: noFix
   notes: Deprecated
-HintCode.UNIGNORABLE_IGNORE:
-  status: needsFix
-  notes: |-
-    Remove the ignore comment (or one code in the comment).
 HintCode.UNNECESSARY_CAST:
   status: hasFix
 HintCode.UNNECESSARY_IMPORT:
@@ -3727,6 +3723,10 @@ WarningCode.UNDEFINED_REFERENCED_PARAMETER:
     Can try to find the correct parameter name.
 WarningCode.UNDEFINED_SHOWN_NAME:
   status: hasFix
+WarningCode.UNIGNORABLE_IGNORE:
+  status: needsFix
+  notes: |-
+    Remove the ignore comment (or one code in the comment).
 WarningCode.UNNECESSARY_CAST_PATTERN:
   status: needsFix
   notes: |-

diff --git a/pkg/analyzer/lib/src/dart/error/hint_codes.g.dart b/pkg/analyzer/lib/src/dart/error/hint_codes.g.dart
@@ -128,16 +128,6 @@ class HintCode extends AnalyzerErrorCode {
     hasPublishedDocs: true,
   );
 
-  ///  Parameters:
-  ///  0: the name of the non-diagnostic being ignored
-  static const HintCode UNIGNORABLE_IGNORE = HintCode(
-    'UNIGNORABLE_IGNORE',
-    "The diagnostic '{0}' can't be ignored.",
-    correctionMessage:
-        "Try removing the name from the list, or removing the whole comment if "
-        "this is the only name in the list.",
-  );
-
   ///  No parameters.
   @Deprecated("Use 'WarningCode.UNNECESSARY_CAST' instead.")
   static const HintCode UNNECESSARY_CAST = HintCode(

diff --git a/pkg/analyzer/lib/src/error/codes.g.dart b/pkg/analyzer/lib/src/error/codes.g.dart
@@ -7092,6 +7092,16 @@ class WarningCode extends AnalyzerErrorCode {
     hasPublishedDocs: true,
   );
 
+  ///  Parameters:
+  ///  0: the name of the non-diagnostic being ignored
+  static const WarningCode UNIGNORABLE_IGNORE = WarningCode(
+    'UNIGNORABLE_IGNORE',
+    "The diagnostic '{0}' can't be ignored.",
+    correctionMessage:
+        "Try removing the name from the list, or removing the whole comment if "
+        "this is the only name in the list.",
+  );
+
   ///  This is the new replacement for [HintCode.UNNECESSARY_CAST].
   static const HintCode UNNECESSARY_CAST = HintCode.UNNECESSARY_CAST;
 

diff --git a/pkg/analyzer/lib/src/error/error_code_values.g.dart b/pkg/analyzer/lib/src/error/error_code_values.g.dart
@@ -619,7 +619,6 @@ const List<ErrorCode> errorCodeValues = [
   HintCode.DIVISION_OPTIMIZATION,
   HintCode.IMPORT_DEFERRED_LIBRARY_WITH_LOAD_FUNCTION,
   HintCode.IMPORT_OF_LEGACY_LIBRARY_INTO_NULL_SAFE,
-  HintCode.UNIGNORABLE_IGNORE,
   HintCode.UNNECESSARY_CAST,
   HintCode.UNNECESSARY_IMPORT,
   HintCode.UNREACHABLE_SWITCH_CASE,
@@ -1047,6 +1046,7 @@ const List<ErrorCode> errorCodeValues = [
   WarningCode.UNDEFINED_HIDDEN_NAME,
   WarningCode.UNDEFINED_REFERENCED_PARAMETER,
   WarningCode.UNDEFINED_SHOWN_NAME,
+  WarningCode.UNIGNORABLE_IGNORE,
   WarningCode.UNNECESSARY_CAST_PATTERN,
   WarningCode.UNNECESSARY_FINAL,
   WarningCode.UNNECESSARY_IGNORE,

diff --git a/pkg/analyzer/lib/src/error/ignore_validator.dart b/pkg/analyzer/lib/src/error/ignore_validator.dart
@@ -119,7 +119,7 @@ class IgnoreValidator {
     //  ignores in the Flutter code base have been cleaned up.
     // for (var unignorableName in unignorable) {
     //   var name = unignorableName.name;
-    //   _errorReporter.reportErrorForOffset(HintCode.UNIGNORABLE_IGNORE,
+    //   _errorReporter.reportErrorForOffset(WarningCode.UNIGNORABLE_IGNORE,
     //       unignorableName.offset, name.length, [name]);
     //   list.remove(unignorableName);
     // }

diff --git a/pkg/analyzer/messages.yaml b/pkg/analyzer/messages.yaml
@@ -19931,12 +19931,6 @@ HintCode:
       If you can't migrate the imported library, then the importing library
       needs to have a language version that is before 2.12, when null safety was
       enabled by default.
-  UNIGNORABLE_IGNORE:
-    problemMessage: "The diagnostic '{0}' can't be ignored."
-    correctionMessage: Try removing the name from the list, or removing the whole comment if this is the only name in the list.
-    comment: |-
-      Parameters:
-      0: the name of the non-diagnostic being ignored
   UNNECESSARY_CAST:
     problemMessage: Unnecessary cast.
     correctionMessage: Try removing the cast.
@@ -25179,6 +25173,12 @@ WarningCode:
 
       var x = min(0, 1);
       ```
+  UNIGNORABLE_IGNORE:
+    problemMessage: "The diagnostic '{0}' can't be ignored."
+    correctionMessage: Try removing the name from the list, or removing the whole comment if this is the only name in the list.
+    comment: |-
+      Parameters:
+      0: the name of the non-diagnostic being ignored
   UNNECESSARY_CAST:
     aliasFor: HintCode.UNNECESSARY_CAST
     comment: This is the new replacement for [HintCode.UNNECESSARY_CAST].