Skip to content

Commit

Permalink
Roll the latest dart_style into the SDK.
Browse files Browse the repository at this point in the history
This has a few changes. One of them affects code even before Dart 3,
though it only touches parameters with metadata on them, which tend to
be rare (outside of uses of the freezed package). It may affect code in
the SDK repo.

The other two are specific records and patterns so won't affect much
existing code. But the formatted behavior before these bug fixes looks
pretty bad, so if it's not too much risky, I think it's worth cherry
picking into the next stable point release.

Change-Id: I1e60d251b474b099c5059ffa63ddb260f0ed1318
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302500
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Michael Thomsen <[email protected]>
Commit-Queue: Bob Nystrom <[email protected]>
  • Loading branch information
munificent authored and Commit Queue committed May 10, 2023
1 parent 25b2a4c commit 73dea24
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@

### Tools

## 3.0.1

### Tools

#### Formatter

- Don't indent parameters with metadata annotations.
- Don't split before `.` following a record literal.
- Don't split unnecessarily in switch expression cases following comments.

## 3.0.0 - 2023-05-10

### Language
Expand Down
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ vars = {
# and land the review.
#
# For more details, see https://github.com/dart-lang/sdk/issues/30164.
"dart_style_rev": "6c9bc10cf2dc6496b2ce863c8d614aa0781abf90", # disable rev_sdk_deps.dart
"dart_style_rev": "156f5c8c3bfe4e3b8e7adc95f7cf24d9500f11c6", # disable rev_sdk_deps.dart
"dartdoc_rev": "d01ddc58600c0d2edbbd953d2074996c36604cfc",
"ffi_rev": "7f4acbd7532d94a793452030ff96bfef8cd96b68",
"file_rev": "b9051806a1fde54066d080a2a3f00333c7bae415",
Expand Down

0 comments on commit 73dea24

Please sign in to comment.