Skip to content

Commit

Permalink
Revert "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12"
Browse files Browse the repository at this point in the history
This reverts commit 03e8ddd.

Reason for revert: Change to hooks does not work with Windows.

Original change's description:
> [co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12
>
> 2021-03-22 [email protected] Fixes #1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
> 2021-03-22 [email protected] Fixes #1027. Typo fixed
> 2021-03-22 [email protected] Fixes #1026. Missed experimental flag added
> 2021-03-22 [email protected] Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems
> 2021-03-19 [email protected] #1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS
>
> Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
> Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303
> Reviewed-by: William Hesse <[email protected]>
> Commit-Queue: Alexander Thomas <[email protected]>

[email protected],[email protected]

Change-Id: I5f66db541034377f5d68424073282080d13fd34b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try
Cq-Include-Trybots: dart2js-nnbd-linux-x64-chrome-try
Cq-Include-Trybots: ddc-nnbd-linux-release-chrome-try
Cq-Include-Trybots: front-end-nnbd-linux-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-debug-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-release-simarm64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-mac-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-win-release-x64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-debug-x64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-simarm64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192380
Reviewed-by: William Hesse <[email protected]>
  • Loading branch information
whesse committed Mar 22, 2021
1 parent 03e8ddd commit 88ee333
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ vars = {
# co19 is a cipd package. Use update.sh in tests/co19[_2] to update these
# hashes. It requires access to the dart-build-access group, which EngProd
# has.
"co19_rev": "ae818220b12ec9c2470519db2c7167cbe4745e12",
"co19_rev": "1abf208ef6428aac8fee6f3175d65b1c59cd15c8",
"co19_2_rev": "cf6eed0535e45413672bb5bb6e65df9f59846372",

# The internal benchmarks to use. See go/dart-benchmarks-internal
Expand Down Expand Up @@ -654,15 +654,9 @@ deps_os = {
}
}

# TODO(iposva): Move the necessary tools so that hooks can be run
# without the runtime being available.
hooks = [
{
"name": "package_config.json",
"pattern": ".",
"action": [
Var('dart_root') + "/tools/sdks/dart-sdk/bin/dart",
Var('dart_root') + "/tools/generate_package_config.dart"
],
},
{
"name": "firefox_jsshell",
"pattern": ".",
Expand Down

0 comments on commit 88ee333

Please sign in to comment.