Skip to content

Commit

Permalink
[VM/AOT] Turn bare instructions on by default
Browse files Browse the repository at this point in the history
Issue #33274

Change-Id: I44850d5906143a53d6b1872eb729364c3a509f9a
Reviewed-on: https://dart-review.googlesource.com/c/91060
Commit-Queue: Martin Kustermann <[email protected]>
Reviewed-by: Siva Annamalai <[email protected]>
  • Loading branch information
mkustermann authored and [email protected] committed Jan 25, 2019
1 parent 8934716 commit 8c439c7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion runtime/vm/flag_list.h
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ constexpr bool kDartPrecompiledRuntime = false;
P(reorder_basic_blocks, bool, true, "Reorder basic blocks") \
C(stress_async_stacks, false, false, bool, false, \
"Stress test async stack traces") \
P(use_bare_instructions, bool, false, "Enable bare instructions mode.") \
P(use_bare_instructions, bool, true, "Enable bare instructions mode.") \
R(support_disassembler, false, bool, true, "Support the disassembler.") \
R(support_il_printer, false, bool, true, "Support the IL printer.") \
C(support_reload, false, false, bool, true, "Support isolate reload.") \
Expand Down
10 changes: 5 additions & 5 deletions tools/bots/test_matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -274,13 +274,13 @@
"options": {
"vm-options": ["--no-enable-malloc-hooks"]
}},
"dartkp-bare-linux-(debug|release)-x64": {
"dartkp-no-bare-linux-(debug|release)-x64": {
"options": {
"vm-options": ["--no-enable-malloc-hooks", "--use-bare-instructions"]
"vm-options": ["--no-enable-malloc-hooks", "--no-use-bare-instructions"]
}},
"dartkp-bare-linux-(debug|release)-(simarm|simarm64)": {
"dartkp-no-bare-linux-(debug|release)-(simarm|simarm64)": {
"options": {
"vm-options": ["--no-enable-malloc-hooks", "--use-bare-instructions"],
"vm-options": ["--no-enable-malloc-hooks", "--no-use-bare-instructions"],
"use-blobs": true
}},
"dartk-(linux|mac)-(debug|release)-(ia32|x64)": { },
Expand Down Expand Up @@ -552,7 +552,7 @@
{
"name": "vm tests",
"arguments": [
"-ndartkp-bare-${system}-${mode}-${arch}"
"-ndartkp-no-bare-${system}-${mode}-${arch}"
],
"fileset": "vm-kernel",
"shards": 10
Expand Down

0 comments on commit 8c439c7

Please sign in to comment.