Skip to content

Commit

Permalink
[dds] Roll chrome_tag, browser_launcher_rev, and add --use-mock-keych…
Browse files Browse the repository at this point in the history
…ain flag to dds

With this roll, Chrome now triggers a dialog on MacOS requesting
credentials. This results in timeouts for
pkg/dds/test/devtools_server/remote_control_test. To avoid user
input, we use a mock keychain instead. The same change has gone
into browser_launcher_rev, and so we include that commit here.

Bug: #56519
Change-Id: I0e0733b658eb09b0775178e617e5ceb42e184ec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381705
Commit-Queue: Srujan Gaddam <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
  • Loading branch information
srujzs authored and Commit Queue committed Aug 22, 2024
1 parent 44cc865 commit ac038f7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ vars = {
"bazel_worker_rev": "02f190b88df771fc8e05c07d4b64ae942c02f456",
"benchmark_harness_rev": "a06785cdfc51538e3556c1d59bb4f03426e9e1c5",
"boolean_selector_rev": "c5468f44fd9ca0ea3435e1a0a84ff9b6fac38261",
"browser_launcher_rev": "fe7ffa13ba59ec6f7d56256f79059344555fdaf2",
"browser_launcher_rev": "fa98c77e7a2fee21a4ad3528dd79da0f4df6bd0f",
"characters_rev": "7633a16a22c626e19ca750223237396315268a06",
"cli_util_rev": "6a0bb9292ea4bb2c9e547af03da4c9948f9556a1",
"clock_rev": "6e43768a0b135a0d36fc886907b70c4bf27117e6",
Expand Down Expand Up @@ -207,7 +207,7 @@ vars = {
# meant to be downloaded by users for local testing. You can self-service
# update these by following the go/dart-engprod/browsers.md instructions.
"download_chrome": False,
"chrome_tag": "128.0.6613.5",
"chrome_tag": "128.0.6613.36",
"download_firefox": False,
"firefox_tag": "129.0",

Expand Down
8 changes: 6 additions & 2 deletions pkg/dds/lib/devtools_server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -627,11 +627,15 @@ class DevToolsServer {
final args = headlessMode
? [
'--headless',
// When running headless, Chrome will quit immediately after loading
// the page unless we have the debug port open.
// When running headless, Chrome will quit immediately after
// loading the page unless we have the debug port open.
'--remote-debugging-port=9223',
'--disable-gpu',
'--no-sandbox',
// When running on MacOS, Chrome may open system dialogs
// requesting credentials. This uses a mock keychain to avoid that
// dialog from blocking.
'--use-mock-keychain',
]
: <String>[];
final proc = await Chrome.start([uriToLaunch.toString()], args: args);
Expand Down

0 comments on commit ac038f7

Please sign in to comment.