Small cleanup tasks. json and proto use the codec abstraction, but th…

…e binary serialization does not, other unrelated cleanup (#67)
dart-lang · Feb 14, 2019 · d6eaba9 · d6eaba9
1 parent dc9516a
commit d6eaba9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,7 +16,7 @@
 
 * Split the json codec from info.dart.
 
-* Introduced `lib/binary_codec.dart` a lighterweight
+* Introduced `lib/binary_serialization.dart` a lighterweight
   serialization/deserialization implementation. This will eventually be used by
   default by dart2js.
 

diff --git a/lib/binary_codec.dart → lib/binary_serialization.dart b/lib/binary_codec.dart → lib/binary_serialization.dart
diff --git a/lib/json_info_codec.dart b/lib/json_info_codec.dart
@@ -49,12 +49,12 @@ class JsonToAllInfoConverter extends Converter<Map<String, dynamic>, AllInfo> {
         (elements['constant'] as Map).values.map((c) => parseConstant(c)));
 
     json['holding'].forEach((k, deps) {
-      var src = registry[k];
+      CodeInfo src = registry[k];
       assert(src != null);
       for (var dep in deps) {
         var target = registry[dep['id']];
         assert(target != null);
-        (src as CodeInfo).uses.add(new DependencyInfo(target, dep['mask']));
+        src.uses.add(new DependencyInfo(target, dep['mask']));
       }
     });
 

diff --git a/test/binary_codec_test.dart → test/binary_serialization_test.dart b/test/binary_codec_test.dart → test/binary_serialization_test.dart
@@ -6,7 +6,7 @@ import 'dart:convert';
 import 'dart:io';
 
 import 'package:dart2js_info/json_info_codec.dart';
-import 'package:dart2js_info/binary_codec.dart' as binary;
+import 'package:dart2js_info/binary_serialization.dart' as binary;
 import 'package:test/test.dart';
 
 class ByteSink implements Sink<List<int>> {