Skip to content

Commit

Permalink
[vm] Enable waitFor for 3.2 release
Browse files Browse the repository at this point in the history
We are going to enable waitFor in 3.2 release
and disable it in 3.3.

This makes migration smoother for users that need
to use Isolate.resolvePackageUriSync which is
only added in 3.2.

The actual removal timeline remains the same:
we will remove waitFor in 3.4.

TEST=ci

Bug: #52121
Change-Id: I1ab7d07f874b3d914f070f1c358fcffaa96da28b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329420
Reviewed-by: Martin Kustermann <[email protected]>
Commit-Queue: Slava Egorov <[email protected]>
  • Loading branch information
mraleph authored and Commit Queue committed Oct 5, 2023
1 parent 0ffbf29 commit f8086ed
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
10 changes: 0 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,6 @@ constraint][language version] lower bound to 3.2 or greater (`sdk: '^3.2.0'`).

- Added `broadcast` parameter to `Stream.empty` constructor.

#### `dart:cli`

- **Breaking change** [#52121][]:
- `waitFor` is disabled by default and slated for removal in 3.4. Attempting
to call this function will now throw an exception. Users that still depend
on `waitFor` can enable it by passing `--enable_deprecated_wait_for` flag
to the VM.

[#52121]: https://github.com/dart-lang/sdk/issues/52121

#### `dart:convert`

- **Breaking change** [#52801][]:
Expand Down
2 changes: 1 addition & 1 deletion runtime/vm/dart_api_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ DEFINE_FLAG(bool,
"Dump common hash tables before snapshotting.");
DEFINE_FLAG(bool,
enable_deprecated_wait_for,
false,
true,
"Enable deprecated dart:cli waitFor. "
"This feature will be fully removed in Dart 3.4 release. "
"See https://dartbug.com/52121.");
Expand Down

0 comments on commit f8086ed

Please sign in to comment.