Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom keyboard shortcut maps (+4) #1056

Closed
lukechurch opened this issue Jan 5, 2012 · 14 comments
Closed

Custom keyboard shortcut maps (+4) #1056

lukechurch opened this issue Jan 5, 2012 · 14 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Milestone

Comments

@lukechurch
Copy link
Contributor

Users have requested either specific keyboard map entries - for e.g. the Run in Browser function, or more generally the ability to setup their own keyboard maps.

This would also help common software keyboard map conflicts, such as Eclipse and QuickSilver both wanting Ctrl+Space on a Mac.

@stevemessick
Copy link
Contributor

Changed the title to: "Custom keyboard shortcut maps (+1)".

@keertip
Copy link
Contributor

keertip commented Feb 1, 2012

Changed the title to: "Custom keyboard shortcut maps (+2)".

@lukechurch
Copy link
Contributor Author

Another user has requested this


Changed the title to: "Custom keyboard shortcut maps (+3)".

@jmesserly
Copy link

It'd be really great to see this feature. I've been waiting for it to use the editor more. Eclipse default keybindings work for me on Win/Linux but they don't work great out of the box on Mac.

I'm going to try hacking my preferences file and see if I can get that working, but I hope we can get a fix soon.

@jmesserly
Copy link

I tried copying preferences file, but no dice =
(as noted in: http://groups.google.com/a/dartlang.org/group/misc/browse_thread/thread/a878e9cb48110c66)


Removed Priority-Medium label.
Added Priority-High label.

@pq
Copy link
Member

pq commented Mar 14, 2012

More user input.


Changed the title to: "Custom keyboard shortcut maps (+4)".

@pq
Copy link
Member

pq commented Mar 14, 2012

Set owner to @pq.

@DartBot
Copy link

DartBot commented Mar 22, 2012

This comment was originally written by [email protected]


This keymapping business makes the editor very uncomfortable to use.

Eclipse does not respect Mac global bindings, so in addition to my peculiar bindings for editor navigation (eg ctrl+i = up), all the "standard" bindings like save (ctrl+s) are crooked.

I'm honestly surprised this isn't more of any issue for the folks working on the editor itself (or are they writing all their Dart in JEdit?).

@pq
Copy link
Member

pq commented Apr 5, 2012

Steve: I think you were looking into this? In any event, I'm not actively... (though happy to pitch in!)


Set owner to @stevemessick.

@DartBot
Copy link

DartBot commented May 31, 2012

This comment was originally written by [email protected]


Some early support in recent builds:
http://www.evernote.com/shard/s5/sh/0f0100ab-9581-4b27-a9e1-fdc1a76456cc/16bb4b7b5eb21e31bd75dfced8f3d738

@clayberg
Copy link

clayberg commented Jun 1, 2012

Added this to the M1 milestone.

@stevemessick
Copy link
Contributor

Key bindings can be modified by writing out a file of current bindings, editing it to suit, and loading it back in. It is a bit inconvenient to use. We'll make it better later.


Added Fixed label.

@DartBot
Copy link

DartBot commented Jun 21, 2012

This comment was originally written by [email protected]


While there is some support for custom bindings, the core navigation commands (line up/down, next/prev char, etc.) are still not complete.

@DartBot
Copy link

DartBot commented Apr 2, 2013

This comment was originally written by [email protected]


Also, I'm unable to set key bindings for menu items that do not have a key binding by default, e.g. "Find Uses" and "Find Overriding Methods". Respective added entries to the key bindings XML file are just ignored.

@lukechurch lukechurch added Type-Enhancement P1 A high priority bug; for example, a single project is unusable or has many test failures labels Apr 2, 2013
@lukechurch lukechurch added this to the M1 milestone Apr 2, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
dart-bot pushed a commit that referenced this issue Jan 18, 2019
…RM64/X64

ARM write barrier goes from

   ldrne lr, [thr, #+508]
   blxne lr
to
   blne <offset>

ARM64 write barrier goes from (similarly X64)

   beq +8
   ldrx lr, [thr, #1056]
   blr lr
to
   beq +4
   bl <offset>

It reduces RX on arm/arm64 by around 0.9%

Though the write barrier wrappers stub has multiple entrypoints (one for
each available register).  Because of this, we modify the relocation
logic to support per-call offsets into the target.

To avoid making the assembler code depend on StubCode/FlowGraphCompiler,
we set a closure, which the assembler can call.

Issue #33274

Change-Id: I9e3d68260cab7ef19ea88f1235c78d6031819d6d
Reviewed-on: https://dart-review.googlesource.com/c/90063
Commit-Queue: Martin Kustermann <[email protected]>
Reviewed-by: Vyacheslav Egorov <[email protected]>
tekknolagi pushed a commit to tekknolagi/dart-assembler that referenced this issue Nov 3, 2020
…RM64/X64

ARM write barrier goes from

   ldrne lr, [thr, #+508]
   blxne lr
to
   blne <offset>

ARM64 write barrier goes from (similarly X64)

   beq +8
   ldrx lr, [thr, dart-lang#1056]
   blr lr
to
   beq +4
   bl <offset>

It reduces RX on arm/arm64 by around 0.9%

Though the write barrier wrappers stub has multiple entrypoints (one for
each available register).  Because of this, we modify the relocation
logic to support per-call offsets into the target.

To avoid making the assembler code depend on StubCode/FlowGraphCompiler,
we set a closure, which the assembler can call.

Issue dart-lang#33274

Change-Id: I9e3d68260cab7ef19ea88f1235c78d6031819d6d
Reviewed-on: https://dart-review.googlesource.com/c/90063
Commit-Queue: Martin Kustermann <[email protected]>
Reviewed-by: Vyacheslav Egorov <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

8 participants