-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we remove ~/ from the num interface and disallow it with doubles? #1782
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
closed-as-intended
Closed as the reported issue is expected behavior
type-enhancement
A request for a change that isn't a bug
Comments
The bug occurs only for compile time constants, not for regular code. This seems like a parser bug to me. I am against removing it from doubles, especially in the context of current double/int murkyness in Javascript implementation. |
I agree. I see no reason to remove it from doubles, even if it reduces to (a/b).toInt(). Removed Type-Defect label. |
Added AsDesigned label. |
floitschG
added
Type-Enhancement
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
closed-as-intended
Closed as the reported issue is expected behavior
labels
Aug 19, 2013
This was referenced Jun 3, 2015
kevmoo
added
type-enhancement
A request for a change that isn't a bug
and removed
type-enhancement
labels
Mar 1, 2016
copybara-service bot
pushed a commit
that referenced
this issue
Nov 7, 2022
… webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. crypto (https://github.com/dart-lang/crypto/compare/7cf89d3..e175a95): e175a95 2022-11-03 Devon Carew refactor tests to use a more compact encoding (#134) dartdoc (https://github.com/dart-lang/dartdoc/compare/179ada0..4b2e01b): 4b2e01b6 2022-11-03 Sam Rawlins Deprecate many elements on ModelElement (#3218) 60cc024a 2022-11-03 Sam Rawlins Make some logging APIs non-nullable (#3245) 01c55118 2022-11-03 István Soós Command-line arguments for limit max file count or total size. (#3231) file (https://github.com/google/file.dart/compare/b2e31cb..b768f79): b768f79 2022-11-07 Devon Carew add dependabot; run the CI weekly (#203) intl (https://github.com/dart-lang/intl/compare/dda8ade..442193c): 442193c 2022-11-07 Fernando Andrade Fix typo on readme (#506) shelf (https://github.com/dart-lang/shelf/compare/592656f..5fd2593): 5fd2593 2022-11-07 Kevin Moore latest mono_repo d1d8dc5 2022-11-07 Kevin Moore shelf: fix lints (#307) 64255e5 2022-11-03 Nate Bosch Prepare to publish shelf_web_socket (#305) test (https://github.com/dart-lang/test/compare/173a36f..f3fb3ab): f3fb3ab6 2022-11-05 stnamco add lack of description to configuration document (#1782) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/66f14ce..13dbc20): 13dbc20 2022-11-07 Kevin Moore update lints (#45) webdev (https://github.com/dart-lang/webdev/compare/069b870..47c1c33): 47c1c33 2022-11-04 Anna Gringauze Added issue references and removed unused library (#1752) 542db40 2022-11-04 Anna Gringauze Update analysis options in dwds (#1777) 1a36ec8 2022-11-03 Elliott Brooks (she/her) Send debug info from injected client to the debug extension (#1772) Change-Id: I65dca831c71fa9487d663cc2a808b78b64424072 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268360 Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Kevin Moore <[email protected]> Commit-Queue: Kevin Moore <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Nov 16, 2022
…ackage_config, path, shelf, term_glyph, test_reflective_loader, webdev, webkit_inspection_protocol, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. cli_util (https://github.com/dart-lang/cli_util/compare/b0adbba..edcf1c3): edcf1c3 2022-11-15 Devon Carew blast_repo fixes (#71) csslib (https://github.com/dart-lang/csslib/compare/ba2eb2d..34203c0): 34203c0 2022-11-15 Kevin Moore blast_repo fixes (#154) dartdoc (https://github.com/dart-lang/dartdoc/compare/08e3098..dc502d0): dc502d08 2022-11-15 Sam Rawlins Move much PackageWarning logic _out_ of PackageGraph, into the enum. (#3251) ad651b15 2022-11-15 Sam Rawlins Move the e2e source-link test to a unit test (#3254) d14c680c 2022-11-11 Sam Rawlins Make many Strings in DocumentationComment non-nullable (#3243) 92afb9bb 2022-11-10 dependabot[bot] Bump github/codeql-action from 2.1.29 to 2.1.31 (#3246) http (https://github.com/dart-lang/http/compare/6339026..d56141d): d56141d 2022-11-11 Brian Quinlan Upgrade to ffigen ^7.2 and remove unnecessary casts (#820) d95a544 2022-11-10 Brian Quinlan Add a more complete implementation for `URLSessionTask`. (#818) intl (https://github.com/dart-lang/intl/compare/442193c..a127902): a127902 2022-11-16 Kevin Moore blast_repo fixes (#510) matcher (https://github.com/dart-lang/matcher/compare/6a9b83b..9051de0): 9051de0 2022-11-15 Kevin Moore blast_repo fixes (#197) mockito (https://github.com/dart-lang/mockito/compare/748e88e..347d3e4): 347d3e4 2022-11-14 Kevin Moore blast_repo fixes (#587) package_config (https://github.com/dart-lang/package_config/compare/cff98c9..abb4aec): abb4aec 2022-11-15 Kevin Moore blast_repo fixes (#127) path (https://github.com/dart-lang/path/compare/58ba22c..12ce876): 12ce876 2022-11-14 hellohuanlin Support more arguments in path.join API (#130) shelf (https://github.com/dart-lang/shelf/compare/5fd2593..1c21047): 1c21047 2022-11-11 Devon Carew update the no-response.yml configuration (#308) term_glyph (https://github.com/dart-lang/term_glyph/compare/ec7cf7b..822cd5b): 822cd5b 2022-11-15 Kevin Moore blast_repo fixes (#29) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/ef934b7..52b6753): 52b6753 2022-11-15 Kevin Moore blast_repo fixes (#42) webdev (https://github.com/dart-lang/webdev/compare/22f6271..3ec168f): 3ec168f 2022-11-15 Anna Gringauze Add --enable-experience flag and pass it to the expression compiler service (#1794) 72272dd 2022-11-10 Elliott Brooks (she/her) Include a settings page for configuring the Dart Debug Extension (#1776) 73839e7 2022-11-10 Elliott Brooks (she/her) Log entire exception message instead of first line (#1782) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/b825c8f..ddb624c): ddb624c 2022-11-14 Kevin Moore blast_repo fixes (#95) yaml (https://github.com/dart-lang/yaml/compare/fda5b15..f699275): f699275 2022-11-15 Devon Carew Merge pull request #131 from dart-lang/blast_repo-2022_11_15T20_23_04 8f6a5f7 2022-11-15 Kevin Moore blast_repo fixes Change-Id: I5d55d733b7f9256edf4f44229cc810e827c23f7d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270240 Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Kevin Moore <[email protected]> Reviewed-by: Kevin Moore <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
closed-as-intended
Closed as the reported issue is expected behavior
type-enhancement
A request for a change that isn't a bug
I just added two bug-reports where both the VM and dartc expected ~/ to take two integers (issue #1780 and 1781).
Maybe we should just remove it.
The text was updated successfully, but these errors were encountered: