-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart:dom indexeddb transaction method signature does not match spec #1812
Comments
The referenced link declares the first type to be anything IDBTransaction transaction( The WebKit IDL specifies the storeName(s) parameter as a list, array and string. [CallWith=ScriptExecutionContext] IDBTransaction transaction(in DOMStringList storeNames, in [Optional=DefaultIsUndefined] unsigned short mode) It seems that this is being damaged somehow by merging. |
Marked this as being blocked by #1852. |
Marked this as being blocked by #1886. |
Fixed at r8369. abstract class IDBDatabase implements EventTarget { Added Fixed label. |
…eivers Fixes #47211 Much of this change is about decision-making based on the _type_ of the function in a FunctionReference, or the receiver of that function, in the case of prefixed identifiers or property access. Previously, there was a rule that only direct references to functions (top-level, local, and method) could be torn off and type-instantiated. That rule has been reversed (#1812), so a lot of unraveling has to be done here. `e.call<...>` is now legal for _any_ generic function-typed expression `e`, which certainly may be an expression without a staticElement. Additionally, `e<...>` is now legal for _any_ generic function-typed expression `e`. Because we no longer resolve PropertyAccess piecemeal, we no longer report UNDEFINED_IDENTIFIER or UNDEFINED_PREFIXED_ELEMENT etc before deciding to check if a tearoff is being made on a function-typed element. The unfortunate side-effect here is some redundant error-reporting. :( I've left TODOs. Change-Id: I62106332e39d528cbd7cdfa5ec831dc56b394b52 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213800 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/4d7dc93..f2bb6e9): f2bb6e92 2022-12-07 Sam Rawlins Bump to 6.1.4 (#3266) fixnum (https://github.com/dart-lang/fixnum/compare/62916f2..e4f5e97): e4f5e97 2022-12-08 Michael Thomsen Change IntegerDivisionByZeroException to UnsupportedError (#100) 3bd726f 2022-12-08 Devon Carew rev the sdk min to 2.19.0-0 (#99) logging (https://github.com/dart-lang/logging/compare/f322480..0373ef8): 0373ef8 2022-12-07 Mushaheed Syed Add a check that throws if a logger name ends with '.' (#123) 6d46d71 2022-12-06 Devon Carew Create no-response.yml (#124) protobuf (https://github.com/dart-lang/protobuf/compare/4f3e328..2706b53): 2706b53 2022-12-07 Mahdi K. Fard Add type to a method parameter (#782) a57c16a 2022-12-07 Mahdi K. Fard Fix a typo (#781) shelf (https://github.com/dart-lang/shelf/compare/1c21047..32e342d): 32e342d 2022-12-08 István Soós Prepare the release of shelf_router_generator (#316) 06e2fe6 2022-12-08 Kevin Moore shelf: drop non-null-safe tests (#317) 98363fd 2022-12-06 Kevin Moore lint: sort pub dependencies ad6af2a 2022-12-06 Kevin Moore shelf_static: move RegExp creation out of every request test (https://github.com/dart-lang/test/compare/4dceb87..73cd754): 73cd7540 2022-12-07 Nate Bosch Record the working directory for VM platform (#1804) e40274a6 2022-12-07 Nate Bosch Restore mono_repo config (#1810) 02d8764e 2022-12-07 Sigurd Meldgaard Use Future for return type in runner `main()`. (#1809) 3d6039b3 2022-12-05 Nate Bosch Merge test selections by path (#1806) webdev (https://github.com/dart-lang/webdev/compare/e39506e..3e2364e): 3e2364e 2022-12-07 Elliott Brooks (she/her) Add the Dart Debugger / Flutter Inspector panels in Chrome DevTools (#1812) c164231 2022-12-07 Elliott Brooks (she/her) Small fix to the extension test (#1811) 4bbb4d0 2022-12-06 Elliott Brooks (she/her) Gracefully handle debugger disconnect events (#1808) d3892cf 2022-12-05 Elliott Brooks (she/her) Refactor puppeteer tests to use `Worker` type (#1809) Change-Id: I42033e849f40f209831cfb344247b24ad7731ff0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274580 Reviewed-by: Nate Bosch <[email protected]> Commit-Queue: Devon Carew <[email protected]>
Revisions updated by `dart tools/rev_sdk_deps.dart`. intl (https://github.com/dart-lang/intl/compare/a127902..881e53e): 881e53e Fri Dec 9 08:01:26 2022 -0800 Copybara-Service Merge pull request #346 from lukepighetti:patch-1 e5ca40d Fri Dec 9 07:00:14 2022 -0800 Copybara-Service Merge pull request #453 from selcukguvel:doc-fix edbfc06 Fri Dec 9 15:34:30 2022 +0100 Moritz Merge branch 'master' into patch-1 b489fdd Fri Dec 9 15:30:23 2022 +0100 Moritz Merge branch 'master' into doc-fix 60a0d8c Fri Dec 9 04:17:04 2022 -0800 Googler Internal change ef953fd Mon Mar 7 16:30:31 2022 +0300 selcukguvel Fix NumberFormat document readability issue - Show "var eurosInUSFormat = .." on a new line aa98b67 Tue Dec 29 15:31:53 2020 -0500 Luke Pighetti Remove 7 year old unimplemented fields test (https://github.com/dart-lang/test/compare/73cd754..09fb067): 09fb0679 Thu Dec 8 14:52:33 2022 -0800 Jacob MacDonald prep packages for publishing (#1814) c8ac4382 Thu Dec 8 14:07:05 2022 -0800 Jacob MacDonald Prepare for Dart 3.0 api removals (#1812) Change-Id: I9a7caed3165d3b65e96001aa029602a09355bce8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274542 Auto-Submit: Michael Thomsen <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
I should be able to do:
db.transaction([storeName]);
But lib/dom/generated/src/frog/IDBDatabase.dart has this signature:
_IDBTransactionJs transaction(String storeName, int mode) native;
Two problems:
First argument should be a List<String>.
Second argument should be optional.
(Technically, both arguments are optional: https://developer.mozilla.org/en/IndexedDB/IDBDatabase#transaction())
The text was updated successfully, but these errors were encountered: