Frog output is not working with Chrome 19 Unstable

[andersjohnsen]

The following dart file:

library("graph");

import('dart:html');

void main() {
  document.queryAll("div.graph");
}

Compiled with latest editor (Build 4745) gives the following exception:

Uncaught TypeError: Cannot call method 'apply' of undefined

at line 622 in the attached file.

It works in Chrome 18 Beta.

Thank you,

• Anders

  ---

  Attachment:
  graph.dart.js (167.64 KB)

[rakudrama]

Do you have the html file?

[rakudrama]

I was not able to repro on dartium, which is usually within a week chrome tip.
It might be because of the contents of your html file.

Do you have a full stack trace?

We will have a new version of dart:html in a few days - that might fix it.

[andersjohnsen]

Try and navigate to http://api.dartlang.org/index.html.

It does not work in Chrome 19 as well, same error.

[rakudrama]

The issue appears to be that in Chrome 19, window reports as having a constructor named 'Window'.
You should be able to verify this by changing the generated code for the local function

  function chrome$typeNameOf() {
    return this.constructor.name;
  }

to

  function chrome$typeNameOf() {
    var name = this.constructor.name;
    if (name == 'Window') return 'DOMWindow';
    return name;
  }

---

Removed the owner.
Removed Area-Frog label.
Added Area-UI, Triaged labels.

[DartBot]

This comment was originally written by [email protected]

---

I got stuck on this tonight also... FWIW I had to hack where '$typeNameOf' early outs for function types:

if (typeof(constructor) == 'function') {
    // The constructor isn't null or undefined at this point. Try
    // to grab hold of its name.
    var name = constructor.name;
    // If the name is a non-empty string, we use that as the type
    // name of this object. On Firefox, we often get 'Object' as
    // the constructor name even for more specialized objects so
    // we have to fall through to the toString() based implementation
    // below in that case.
    if (name && typeof(name) == 'string' && name != 'Object') return name;
  }

to be:

if (name && typeof(name) == 'string' && name != 'Object') {
      if (name == 'Window') {
        name = 'DOMWindow';
      } else if (name == 'Document') {
        name = 'HTMLDocument';
      } else if (name == 'XMLDocument') {
        name = 'Document';
      }
      return name;
    }

I dunno if this is a good fix at all but it fixed the following 2 lines of code in my app:

window.on.keyUp.add(onKeyUp);
document.body.nodes.add(display.instance);

[kasperl]

Set owner to @kasperl.
Removed Priority-Medium, Area-UI labels.
Added Priority-High, Area-Frog, Accepted labels.

[kasperl]

CL out for review: https://chromiumcodereview.appspot.com/9616002/.

---

Added Started label.

[kasperl]

Fixed in r5008.

---

Added Fixed label.